Attachment 120466 Details for Bug 94069 – stash this here while I play with some other aspects

[patch] stash this here while I play with some other aspects

0001-Resolves-tdf-94069-call-setVisible-when-setDesignMod.patch (text/plain), 1.11 KB, created by Caolán McNamara on 2015-11-10 20:38:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Caolán McNamara

Created: 2015-11-10 20:38:12 UTC

Size: 1.11 KB

patch

obsolete

>From 32a190a172426e7290fac64d4903281436b92782 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Caol=C3=A1n=20McNamara?= <caolanm@redhat.com>
>Date: Tue, 10 Nov 2015 20:37:00 +0000
>Subject: [PATCH] Resolves: tdf#94069 call setVisible when setDesignMode is
> called
>
>void UnoControl::setDesignMode calls setVisible on the XWindow
>so it seems sensible that FmXGridPeer::setDesignMode should
>also do so. The desirable side effect is that moving the window
>in design mode then is moving a un-shown window so nothing
>is invalidated so the paint loop doesn't happen.
>
>Change-Id: Ic5a4ba62590372bec15a29b993b73d6dfb94a8a9
>---
> svx/source/fmcomp/fmgridif.cxx | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/svx/source/fmcomp/fmgridif.cxx b/svx/source/fmcomp/fmgridif.cxx
>index 6136657..e91d2f3 100644
>--- a/svx/source/fmcomp/fmgridif.cxx
>+++ b/svx/source/fmcomp/fmgridif.cxx
>@@ -1693,6 +1693,8 @@ void FmXGridPeer::setDesignMode(sal_Bool bOn) throw( RuntimeException, std::exce
>             static_cast<FmGridControl*>(pWin)->SetDesignMode(bOn);
>     }
> 
>+    setVisible(!bOn);
>+
>     if (bOn)
>         DisConnectFromDispatcher();
>     else
>-- 
>2.5.0
>

Actions: View

Attachments on bug 94069: 118555 | 119142 | 120466