Attachment 140629 Details for Bug 116396 – Pair of findings (with the debugger)

Pair of findings (with the debugger)

DebugRealizations.txt (text/plain), 4.04 KB, created by Juergen Funk on 2018-03-14 09:24:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Juergen Funk

Created: 2018-03-14 09:24:13 UTC

Size: 4.04 KB

patch

obsolete

>Pair of findings (with the debugger)
>
>
>
>LO, start with the Start Center, now add WollMux as Extention, if you exit with the Restart button, LO will be terminated properly.
>But if the same as above only with the difference "Start later" and now you close the start center (the X in the upper right corner) 
>then the window will be closed but LO is not terminated.
>Here are the steps to do it where/how/what (master aa02ed306f7c633bbffede16e44e8e736977ace4, --enable-dbgutil)
>
>When embedding WollMux, the following is used
>In "binaryurp/source/bridgefactory.cxx:101" this method called" BridgeFactory::createBridge".
>Now here the history when "Restart" is pressed (Will be closed via OfficeRestartManager::get (context)->requestRestart).
>
>Here the dialog is called (with restart) "desktop/source/deployment/gui/dp_gui_dialog2.cxx:1045".
>If the button "Restart" is pressed,"svtools/source/dialogs/restartdialog.cxx:108" then
>here lands "comphelper/source/misc/office restart manager.cxx:109" there will be LO here
>"framework/source/services/desktop.cxx:212" terminated.
>
>Here now the progression if "Later" is pressed and with the X in the upper right corner is closed.
>The "framework/source/dispatch/closedispatcher.cxx:247" CloseDispatcher::impl_asyncCallback called
>And here is the problem "framework/source/dispatch/closedispatcher.cxx:294" there now comes back with 1
>("BridgeFactory::createBridge") and therefore "framework/source/dispatch/closedispatcher.cxx:317" not the
>terminate-flag set but only the CloseFrame which says "framework/source/dispatch/closedispatcher.cxx:402" is not executed, hanger.
>
>Here now the history if "Later" is pressed and closed with File-> "Exit LibreofficeDev".
>It will return to "sfx2/source/appl/appserv.cxx:322" and then it will be terminated (no check of "BridgeFactory::createBridge"), 
>there should be no difference if it is closed via the menu via the close button or via requestRestart LO.
>To recapitulate
>
>there are three (which I've seen now) methods calling xDesktop->terminate (), but with different checks, which can cause the LO to 
>not terminate properly
>
>    âframework/source/dispatch/closedispatcher.cxx:247â CloseDispatcher::impl_asyncCallback 
>
>Here you will find most of the tests, which also cause the suspension.
>This is called by the X in the upper right-hand corner.
>
>    âcomphelper/source/misc/officerestartmanager.cxx:109â OOfficeRestartManager::notify 
>
>Here the terminate method is called almost directly
>This is called by OfficeRestartManager::: get (context)->requestRestart
>
>    âsfx2/source/appl/appserv.cxx:322â SfxApplication::MiscExec_Impl 
>
>Here again several checks are carried out, but the "BridgeFactory:: createBridge" is missing, so it will be terminated correctly.
>This is called by the File-> "Exit LibreOfficeDev3
>
>
>
>Now to JAVA
>
>With Java I have set a breakpoint here "jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx:805"
>
>If I now press the button "Later" and open the Writer, it will NOT be started (WollMux works), if I now end LO (right), then 
>the "BridgeFactory::createBridge "is not used for this, the breakpoint there will be an exception and it will be caught and 
>thus the "setjmp" will be executed, and therefore the initialization was not executed correctly, so here comes 
>"jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx:812" always returns an error! = 0, therefore WollMux does not work.
>I have tested the same with LO 4.1, because the same thing happens (also the same JAVA-function) only with the difference that 
>the exception doesn't come to us (I can see it in the debugger) so WollMux works here.
>
>The question here is, is the InitCall correct because there is always this exception, and because the whole thing works in the 
>release, I suppose that the same thing happens as with LO 4.1 I would have to test it again.
>The other question is if WollMux is registered, the Java is not used at all but realized via BridgeFactory. Why is it not always 
>done this way, somehow I don't really understand.
>
>Even if I do the "Restart" after adding WollMux and then restart LO, the WollMux does not work as described.
>
>

Actions: View

Attachments on bug 116396: 140629