Attachment 141311 Details for Bug 100925 – debugging patch

[patch] debugging patch

0001-debugging-hacks.patch (text/plain), 1.96 KB, created by Caolán McNamara on 2018-04-12 14:01:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Caolán McNamara

Created: 2018-04-12 14:01:50 UTC

Size: 1.96 KB

patch

obsolete

>From a1523f671d463a070dd008c08b631dc15b7b4510 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Caol=C3=A1n=20McNamara?= <caolanm@redhat.com>
>Date: Thu, 12 Apr 2018 14:53:20 +0100
>Subject: [PATCH] debugging hacks
>
>with this in place, background should go red on start of overwrite.
>Is the old text visible ?
>
>additionally with
>
>export SC_NOINLINETEXT=1
>
>the new text is not written at all on new text, is the old text visible ?
>
>Change-Id: I2ffff7e8e989b91821869d8b75a59728ac513d1b
>---
> sc/source/ui/view/gridwin4.cxx | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
>diff --git a/sc/source/ui/view/gridwin4.cxx b/sc/source/ui/view/gridwin4.cxx
>index 0561a41c3d9f..496938230b09 100644
>--- a/sc/source/ui/view/gridwin4.cxx
>+++ b/sc/source/ui/view/gridwin4.cxx
>@@ -976,7 +976,7 @@ void ScGridWindow::DrawContent(OutputDevice &rDevice, const ScTableInfo& rTableI
>         SCCOL nCol2 = pViewData->GetEditEndCol();
>         SCROW nRow2 = pViewData->GetEditEndRow();
>         rDevice.SetLineColor();
>-        rDevice.SetFillColor(pEditView->GetBackgroundColor());
>+        rDevice.SetFillColor(COL_RED);
>         Point aStart = pViewData->GetScrPos( nCol1, nRow1, eWhich );
>         Point aEnd = pViewData->GetScrPos( nCol2+1, nRow2+1, eWhich );
> 
>@@ -1024,8 +1024,11 @@ void ScGridWindow::DrawContent(OutputDevice &rDevice, const ScTableInfo& rTableI
>         rDevice.DrawRect(rDevice.PixelToLogic(aBackground));
> 
>         // paint the editeng text
>-        tools::Rectangle aEditRect(Point(nScrX, nScrY), Size(aOutputData.GetScrW(), aOutputData.GetScrH()));
>-        pEditView->Paint(rDevice.PixelToLogic(aEditRect), &rDevice);
>+        if (!getenv("SC_NOINLINETEXT"))
>+        {
>+            tools::Rectangle aEditRect(Point(nScrX, nScrY), Size(aOutputData.GetScrW(), aOutputData.GetScrH()));
>+            pEditView->Paint(rDevice.PixelToLogic(aEditRect), &rDevice);
>+        }
>         rDevice.SetMapMode(MapMode(MapUnit::MapPixel));
> 
>         // restore the cursor it was originally visible
>-- 
>2.14.3
>

Actions: View

Attachments on bug 100925: 126394 | 130206 | 130207 | 134538 | 141311 | 141313