Attachment 141313 Details for Bug 100925 – does this make any difference ?

[patch] does this make any difference ?

0001-debugging-hacks.patch (text/plain), 2.42 KB, created by Caolán McNamara on 2018-04-12 16:57:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Caolán McNamara

Created: 2018-04-12 16:57:49 UTC

Size: 2.42 KB

patch

obsolete

>From 90c120df6bf777edc1c67e7d9c8bac619e359edd Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Caol=C3=A1n=20McNamara?= <caolanm@redhat.com>
>Date: Thu, 12 Apr 2018 14:53:20 +0100
>Subject: [PATCH] debugging hacks
>
>seeing as the bg is *not* going red straightaway I wonder if it helps
>to hit it with some textoutput before trying to change the color.
>to see if the rhbz#1283420 bodge in X11CairoTextRender::getCairoContext()
>might shake it loose
>
>----old----
>
>with this in place, background should go red on start of overwrite.
>Is the old text visible ?
>
>additionally with
>
>export SC_NOINLINETEXT=1
>
>the new text is not written at all on new text, is the old text visible ?
>
>Change-Id: I2ffff7e8e989b91821869d8b75a59728ac513d1b
>---
> sc/source/ui/view/gridwin4.cxx | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
>diff --git a/sc/source/ui/view/gridwin4.cxx b/sc/source/ui/view/gridwin4.cxx
>index 0561a41c3d9f..08b3c5280294 100644
>--- a/sc/source/ui/view/gridwin4.cxx
>+++ b/sc/source/ui/view/gridwin4.cxx
>@@ -976,7 +976,7 @@ void ScGridWindow::DrawContent(OutputDevice &rDevice, const ScTableInfo& rTableI
>         SCCOL nCol2 = pViewData->GetEditEndCol();
>         SCROW nRow2 = pViewData->GetEditEndRow();
>         rDevice.SetLineColor();
>-        rDevice.SetFillColor(pEditView->GetBackgroundColor());
>+        rDevice.SetFillColor(COL_RED);
>         Point aStart = pViewData->GetScrPos( nCol1, nRow1, eWhich );
>         Point aEnd = pViewData->GetScrPos( nCol2+1, nRow2+1, eWhich );
> 
>@@ -1021,11 +1021,16 @@ void ScGridWindow::DrawContent(OutputDevice &rDevice, const ScTableInfo& rTableI
>         }
> 
>         // paint the background
>-        rDevice.DrawRect(rDevice.PixelToLogic(aBackground));
>+        tools::Rectangle aLogicRect(rDevice.PixelToLogic(aBackground));
>+        rDevice.DrawText(aLogicRect.BottomLeft(), "xxxx");
>+        rDevice.DrawRect(aLogicRect);
> 
>         // paint the editeng text
>-        tools::Rectangle aEditRect(Point(nScrX, nScrY), Size(aOutputData.GetScrW(), aOutputData.GetScrH()));
>-        pEditView->Paint(rDevice.PixelToLogic(aEditRect), &rDevice);
>+        if (!getenv("SC_NOINLINETEXT"))
>+        {
>+            tools::Rectangle aEditRect(Point(nScrX, nScrY), Size(aOutputData.GetScrW(), aOutputData.GetScrH()));
>+            pEditView->Paint(rDevice.PixelToLogic(aEditRect), &rDevice);
>+        }
>         rDevice.SetMapMode(MapMode(MapUnit::MapPixel));
> 
>         // restore the cursor it was originally visible
>-- 
>2.14.3
>

Actions: View

Attachments on bug 100925: 126394 | 130206 | 130207 | 134538 | 141311 | 141313