Bugzilla – Attachment 151139 Details for
Bug 125088
Default buttons have the wrong text color on macOS
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch which resolves this issue
button-color.patch (text/plain), 1005 bytes, created by
Andrew Hyatt
on 2019-05-02 18:43:50 UTC
(
hide
)
Description:
Patch which resolves this issue
Filename:
MIME Type:
Creator:
Andrew Hyatt
Created:
2019-05-02 18:43:50 UTC
Size:
1005 bytes
patch
obsolete
>diff --git a/vcl/source/control/button.cxx b/vcl/source/control/button.cxx >index 93aed205fdcb..74434f82ab9f 100644 >--- a/vcl/source/control/button.cxx >+++ b/vcl/source/control/button.cxx >@@ -812,6 +812,16 @@ void PushButton::ImplDrawPushButtonContent(OutputDevice* pDev, DrawFlags nDrawFl > > if ( nDrawFlags & DrawFlags::Mono ) > aColor = COL_BLACK; >+#ifdef __APPLE__ >+ else if ((nButtonFlags & DrawButtonFlags::Default) && !(GetStyle() & WB_FLATBUTTON)) >+ { >+ // Make text color white if the button is a default control on macOS. >+ // Without this you get a button with a blue background and blue text >+ // which stands out as not looking right on macOS where default buttons >+ // have white text and a blue background. >+ aColor = COL_WHITE; >+ } >+#endif > else if( (nButtonFlags & DrawButtonFlags::Highlight) && IsNativeControlSupported(ControlType::Pushbutton, ControlPart::Entire) ) > { > if (nButtonFlags & DrawButtonFlags::Pressed)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Actions:
View
Attachments on
bug 125088
: 151139