Attachment 158663 Details for Bug 131280 – Patch demonstrating workaround (not meant to be merged as is)

[patch] Patch demonstrating workaround (not meant to be merged as is)

0001-DEMO-HACK-tdf-131280-Ignore-Control-StateChanged-for.patch (text/plain), 1.57 KB, created by Michael Weghorn on 2020-03-13 07:32:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Weghorn

Created: 2020-03-13 07:32:58 UTC

Size: 1.57 KB

patch

obsolete

>From 72e68b453163e89f2408fa72b57f70eedce4dfb6 Mon Sep 17 00:00:00 2001
>From: Michael Weghorn <m.weghorn@posteo.de>
>Date: Fri, 13 Mar 2020 08:25:36 +0100
>Subject: [PATCH] DEMO/HACK: tdf#131280 Ignore Control::StateChanged for zoom
>
>Quick workaround for the Android Viewer case, s. inline
>comment and tdf#131280 for more details.
>
>TODO: fix properly instead
>
>Change-Id: Id46f9f804bc488730c0b6b9bfd20415172da4d4a
>---
> vcl/source/control/ctrl.cxx | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
>diff --git a/vcl/source/control/ctrl.cxx b/vcl/source/control/ctrl.cxx
>index 522446561a79..6b984456b935 100644
>--- a/vcl/source/control/ctrl.cxx
>+++ b/vcl/source/control/ctrl.cxx
>@@ -259,6 +259,20 @@ bool Control::EventNotify( NotifyEvent& rNEvt )
> 
> void Control::StateChanged( StateChangedType nStateChange )
> {
>+    // Workaround for tdf#131280:
>+    // At a quick analysis, this caused invalidation requests "without end"
>+    // otherwise for the Android Viewer case;
>+    // (*possibly*, because core sent invalidation request to Java part,
>+    // Java part triggered rerendering, which caused an invalidation
>+    // request being sent to the Java part as a consequence, so Java
>+    // part triggered rerendering,...
>+    // (just a quick guess, haven't looked into that more deeply so far)
>+    // TODO: find a proper fix instead
>+    if( nStateChange == StateChangedType::Zoom)
>+    {
>+        return;
>+    }
>+
>     if( nStateChange == StateChangedType::InitShow   ||
>         nStateChange == StateChangedType::Visible    ||
>         nStateChange == StateChangedType::Zoom       ||
>-- 
>2.25.1
>

Actions: View

Attachments on bug 131280: 158602 | 158663