Attachment 42528 Details for Bug 33523 – patch committed

[patch] patch committed

0001-Resolves-fdo-33523-fix-scrollbars-in-themes-that-hav.patch (text/plain), 1.83 KB, created by Caolán McNamara on 2011-01-26 08:09:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Caolán McNamara

Created: 2011-01-26 08:09:05 UTC

Size: 1.83 KB

patch

obsolete

>From 53218185dc078431350632217d9bcd9a9a717500 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Caol=C3=A1n=20McNamara?= <caolanm@redhat.com>
>Date: Wed, 26 Jan 2011 16:08:02 +0000
>Subject: [PATCH] Resolves: fdo#33523 fix scrollbars in themes that have no up/down buttons
>
>---
> vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx |   10 ++++++++++
> 1 files changed, 10 insertions(+), 0 deletions(-)
>
>diff --git a/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx b/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx
>index 39e6627..2f9575f 100644
>--- a/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx
>+++ b/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx
>@@ -1055,6 +1055,12 @@ BOOL GtkSalGraphics::getNativeControlRegion(  ControlType nType,
>         rNativeBoundingRegion = NWGetScrollButtonRect( m_nScreen, nPart, rControlRegion );
>         rNativeContentRegion = rNativeBoundingRegion;
> 
>+        //See fdo#33523, possibly makes sense to do this test for all return values
>+        if (!rNativeContentRegion.GetWidth())
>+            rNativeContentRegion.Right() = rNativeContentRegion.Left() + 1;
>+        if (!rNativeContentRegion.GetHeight())
>+            rNativeContentRegion.Bottom() = rNativeContentRegion.Top() + 1;
>+
>         returnVal = TRUE;
>     }
>     if( (nType == CTRL_MENUBAR) && (nPart == PART_ENTIRE_CONTROL) )
>@@ -1622,6 +1628,10 @@ BOOL GtkSalGraphics::NWPaintGTKScrollbar( ControlType, ControlPart nPart,
>     NWSetWidgetState( gWidgetData[m_nScreen].gBtnWidget, nState, stateType );
>     style = GTK_WIDGET( scrollbarWidget )->style;
> 
>+    gtk_style_apply_default_background( m_pWindow->style, gdkDrawable, TRUE,
>+                                        GTK_STATE_NORMAL, gdkRect,
>+                                        x, y, w, h );
>+
>     // ----------------- TROUGH
>     gtk_paint_flat_box( m_pWindow->style, gdkDrawable,
>                         GTK_STATE_NORMAL, GTK_SHADOW_NONE, gdkRect,
>-- 
>1.7.3.5
>

Actions: View

Attachments on bug 33523: 42517 | 42528