Attachment 44938 Details for Bug 35745 – like so

[patch] like so

unused.basic.stuff.patch (text/plain), 1.72 KB, created by Caolán McNamara on 2011-03-28 09:16:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Caolán McNamara

Created: 2011-03-28 09:16:07 UTC

Size: 1.72 KB

patch

obsolete

>diff --git a/sc/source/core/data/documen2.cxx b/sc/source/core/data/documen2.cxx
>index 1947a7a..9be4a8f 100644
>--- a/sc/source/core/data/documen2.cxx
>+++ b/sc/source/core/data/documen2.cxx
>@@ -1085,12 +1085,12 @@ sal_uLong ScDocument::TransferTab( ScDocument* pSrcDoc, SCTAB nSrcPos,
>         SfxObjectShell* pSrcShell = pSrcDoc ? pSrcDoc->GetDocumentShell() : NULL;
>         if ( pSrcShell )
>         {
>-            StarBASIC* pStarBASIC = pSrcShell ? pSrcShell->GetBasic() : NULL;
>             String aLibName( RTL_CONSTASCII_USTRINGPARAM( "Standard" ) );
>-            if ( pSrcShell && pSrcShell->GetBasicManager()->GetName().Len() > 0 )
>+            if ( pSrcShell )
>             {
>-                aLibName = pSrcShell->GetBasicManager()->GetName();
>-                pStarBASIC = pSrcShell->GetBasicManager()->GetLib( aLibName );
>+                BasicManager* pBasMgr = pSrcShell->GetBasicManager();
>+                if (pBasMgr && pBasMgr->GetName().Len() > 0)
>+                    aLibName = pBasMgr->GetName();
>             }
> 
>             String sCodeName;
>diff --git a/sc/source/core/tool/interpr4.cxx b/sc/source/core/tool/interpr4.cxx
>index a30ac55..f171641 100755
>--- a/sc/source/core/tool/interpr4.cxx
>+++ b/sc/source/core/tool/interpr4.cxx
>@@ -3082,13 +3082,7 @@ void ScInterpreter::ScMacro()
>     aMacroStr += pMethod->GetName();
>     String aBasicStr;
>     if (pObject->GetParent())
>-    {
>         aBasicStr = pObject->GetParent()->GetName();    // Dokumentenbasic
>-        const SfxFilter* pFilter = NULL;
>-        SfxMedium* pMedium = pDok->GetDocumentShell()->GetMedium();
>-        if ( pMedium )
>-            pFilter = pMedium->GetFilter();
>-    }
>     else
>         aBasicStr = SFX_APP()->GetName();               // Applikationsbasic
>

Actions: View

Attachments on bug 35745: 44938