Bugzilla – Attachment 57987 Details for
Bug 46926
PyUNO structure comparisons broken (always false)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Correct rich comparison of wrapped objects
pyuno.cxx.diff (text/plain), 847 bytes, created by
David Bolen
on 2012-03-03 15:14:11 UTC
(
hide
)
Description:
Correct rich comparison of wrapped objects
Filename:
MIME Type:
Creator:
David Bolen
Created:
2012-03-03 15:14:11 UTC
Size:
847 bytes
patch
obsolete
>diff --git a/pyuno/source/module/pyuno.cxx b/pyuno/source/module/pyuno.cxx >index 2bfbe7b..5033eee 100644 >--- a/pyuno/source/module/pyuno.cxx >+++ b/pyuno/source/module/pyuno.cxx >@@ -641,7 +641,7 @@ static PyObject* PyUNO_cmp( PyObject *self, PyObject *that, int op ) > { > raisePyExceptionWithAny( makeAny( e ) ); > } >- return Py_False; >+ return (op == Py_EQ ? Py_False : Py_True); > } > > static PyTypeObject PyUNOType = >@@ -654,7 +654,7 @@ static PyTypeObject PyUNOType = > (printfunc) 0, > (getattrfunc) PyUNO_getattr, > (setattrfunc) PyUNO_setattr, >- 0, >+ (cmpfunc) 0, > (reprfunc) PyUNO_repr, > 0, > 0, >@@ -665,7 +665,7 @@ static PyTypeObject PyUNOType = > (getattrofunc)0, > (setattrofunc)0, > NULL, >- 0, >+ Py_TPFLAGS_HAVE_RICHCOMPARE, > NULL, > (traverseproc)0, > (inquiry)0,
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=57987">View the attachment on a separate page</a>.</b>
View Attachment As Raw
Actions:
View
Attachments on
bug 46926
:
57987
|
58017
|
58412