| Summary: | Status bar functions - Selection Icon not working properly on left mouse click | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Marco Filippozzi <marco.filippozzi> |
| Component: | Writer | Assignee: | Kshitij <kshitijpathania> |
| Status: | RESOLVED FIXED | ||
| Severity: | trivial | CC: | 79045_79045, admin, harald.koester, heiko.tietze, libretraining.tutorials, lothar.becker, marina.latini, mentoring, philipz85, samuel.mehrbrodt, vsfoote |
| Priority: | medium | Keywords: | difficultyInteresting, easyHack, regression, skillCpp, topicUI |
| Version: | 4.4.0.1 rc | ||
| Hardware: | x86-64 (AMD64) | ||
| OS: | Linux (All) | ||
| Whiteboard: | target:6.1.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 86066 | ||
|
Description
Marco Filippozzi
2016-06-14 13:01:13 UTC
Not present on: Version: 4.3.7.2 Build ID: 8a35821d8636a03b8bf4e15b48f59794652c68ba OS: openSUSE Leap 42.1 (x86_64) Confirming, but several of the Satus bar buttons have functions that differ depending on a Left Mouse or a Right Mouse selection. Zoom level, or Page style for example. The Left mouse opens a dialog, the right mouse a pick list. On the Selection button -- right mouse opens the pick list. Left mouse opens the list and advances the selection type. Originally, when Kendy changed the mode selection to a menu with https://cgit.freedesktop.org/libreoffice/core/commit/?id=f76fde91c4103812d924b973cec83a7b316a1f05 --both the Left and Right mouse actions had the pick list menu. I looked, but couldn't find where the behavior was changed. But don't know that is necessarily wrong--but could be unintended of other changes. @Kendy? =-ref-= http://opengrok.libreoffice.org/xref/core/svx/source/stbctrls/selctrl.cxx http://opengrok.libreoffice.org/xref/core/svx/source/stbctrls/stbctrls.h http://opengrok.libreoffice.org/xref/core/svx/source/stbctrls/stbctrls.src If we want to limit the menu only to the right click, I think the right thing to do is to check rEvt in: bool SvxSelectionModeControl::MouseButtonDown( const MouseEvent& rEvt ) in file https://cgit.freedesktop.org/libreoffice/core/tree/svx/source/stbctrls/selctrl.cxx that it is the right button that triggered the action, and if it is, show the menu. *** Bug 88065 has been marked as a duplicate of this bug. *** assigned to myself, will try to fix the easyhack (In reply to Marco Filippozzi from comment #5) > assigned to myself, will try to fix the easyhack Welcome, looking forward to see your patch. We have created a step by step guide to help you: https://wiki.documentfoundation.org/Development/GetInvolved have fun jan i a polite ping, still working on this issue ? *** Bug 86570 has been marked as a duplicate of this bug. *** Samuel's fix in bug 82707 broke this functionality. This seems about right in current master. However, it's broken in 5.1. Didn't test 5.2. A polite ping, still working on solving this bug ? According to comment 10, this bug seems solved. (In reply to Samuel Mehrbrodt (CIB) from comment #10) > This seems about right in current master. However, it's broken in 5.1. > Didn't test 5.2. Not sure which master you tested, but it is still broken. Version: 5.3.0.0.beta1+ Build ID: a1f6159db30e2463b118c1571bb01a09356b7c49 CPU Threads: 2; OS Version: Linux 3.19; UI Render: default; VCL: gtk2; Layout Engine: new; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:libreoffice-5-3, Time: 2016-12-08_00:34:06 Locale: en-US (en_US.UTF-8); Calc: group A polite ping still working on this issue ? Also bug found in, Version: 5.2.5.1 Build ID: 5.2.5-1 CPU Threads: 4; OS Version: Linux 4.9; UI Render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); Calc: group. Still confirming in Version: 5.4.0.0.alpha1+ Build-ID: 2b1737f648024328390bf44c4f2c614e748a92fd CPU-Threads: 2; Betriebssystem:Windows 6.1; UI-Render: Standard; TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2017-05-07_02:29:33 Gebietsschema: de-DE (de_DE); Calc: group Left click turns automatically the selection of the style one down and show the list after changing the selection style. A polite ping, still working on this bug A polite ping, still working on this bug A polite ping, still working on this bug A polite ping, still working on this bug A polite ping, still working on this bug? A polite ping, still working on this bug? A polite ping, still working on this bug? Hi! I would like to work on this bug. I have submitted the patch can someone review that https://gerrit.libreoffice.org/#/c/48279/ Kshitij Pathania committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=de1bb0878fc7d7eb6071ec94d770712648013075 tdf#100370 Selection icon now working properly on mouse click It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Checked with version 6.1.2 (64 bit, Win 10). Works as expected according original description of this bug. Hence bug closed. Thanks for fixing. Comment: It's still not transparent which selection is currently used. You have to move the mouse pointer above the icon in order to get a tip with the current mode. I would expect different icons as described in bug 88477. |