| Summary: | Bad marker icons in Galaxy and Highcontrast theme | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Regina Henschel <rb.henschel> |
| Component: | UI | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | ilmari.lauhakangas, philipz85, xiscofauli |
| Priority: | low | Keywords: | regression |
| Version: | 4.1.6.2 release | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 103537, 110745 | ||
| Attachments: |
Galaxy, case working in gluepoint edit mode
Tango, in gluepoint edit mode Galaxy, in connector attach mode Tango, in connector attach mode |
||
Created attachment 126577 [details]
Tango, in gluepoint edit mode
Created attachment 126578 [details]
Galaxy, in connector attach mode
Created attachment 126579 [details]
Tango, in connector attach mode
(In reply to Regina Henschel from comment #0) > You see the > difference immediately, if you look at the bottom left side of the files. > difference to /core/icon-themes/tango/svx/res/markers.png Confirmed. It is a regression that started in the 4.2 branch. Version: 5.3.0.0.alpha0+ Build ID: 07966a9999b0b3f27e1adeea1f4c97b3ba2944fa CPU Threads: 2; OS Version: Linux 3.19; UI Render: default; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2016-08-05_23:22:09 Locale: en-US (en_US.UTF-8); Calc: group Adding keyword 'bibisectRequest'. It is fixed for Galaxy by Tomaž Vajngerl with commit https://cgit.freedesktop.org/libreoffice/core/commit/?id=9b71cb737174c4a3eb9a1bcdbc5424cf34d6e6a6 In future the markers will be stored in independent, single icons, see commit https://cgit.freedesktop.org/libreoffice/core/commit/?id=681c2c3f59863d1f2d0123a92ee63baf84e18dfc (In reply to Regina Henschel from comment #7) > It is fixed for Galaxy by Tomaž Vajngerl with commit > https://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=9b71cb737174c4a3eb9a1bcdbc5424cf34d6e6a6 > > > In future the markers will be stored in independent, single icons, see > commit > https://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=681c2c3f59863d1f2d0123a92ee63baf84e18dfc Then let's close as fixed. Galaxy is now removed and Sifr replaced highcontrast and I tested Colibre & Sifr and everything seems good. |
Created attachment 126576 [details] Galaxy, case working in gluepoint edit mode The file markers.png in /core/icon-themes/galaxy/svx/res/markers.png and /core/icon-themes/hicontrast/svx/res/markers.png have not been adapted to the new way of fetching the markers for gluepoints. The normal marker should be at position 16|68 to 22|74 and the version for selected marker should be at position 16|77 to 22|82. These areas have to be adapted. You see the difference immediately, if you look at the bottom left side of the files. The attached files show the effect in the UI.