Bug 101351

Summary: Combobox pulldown buttons are invisible in GTK3 with dark themes like Ambiance
Product: LibreOffice Reporter: Yotam Benshalom <benshalom>
Component: UIAssignee: Not Assigned <libreoffice-bugs>
Status: RESOLVED WORKSFORME    
Severity: normal CC: aron.budea, benshalom, bjoern.michaelsen, ilmari.lauhakangas
Priority: medium    
Version: 5.1.4.2 release   
Hardware: All   
OS: All   
Whiteboard:
Crash report or crash signature: Regression By:
Attachments: Missing pulldown on comboboxes in gtk3 rtl ui, also misaligned combobox content
Writer screenshot

Description Yotam Benshalom 2016-08-06 11:25:34 UTC
Created attachment 126629 [details]
Missing pulldown on comboboxes in gtk3 rtl ui, also misaligned combobox content

Combobox pulldown button is missing in GTK3 RTL UI.
Also, the contents of the combo box should be aligned to the right in RTL UI, not to the left.
This is quite similar to a GTK2 bug that was already resolved: bug #40950.
See attached screen shot.
Comment 1 Buovjaga 2016-08-07 16:22:56 UTC
Pulldowns are there for me, tested with SAL_RTL_ENABLED=1
Was the problem already in 5.1.x?
For the alignment issue, check existing ones and then file a new report, if no report exists.

Version: 5.1.5.2
Build ID: 1:5.1.5~rc2-0ubuntu1~xenial1
CPU Threads: 4; OS Version: Linux 4.4; UI Render: default; 
Locale: en-US (en_US.UTF-8); Calc: group

Arch Linux 64-bit, KDE Plasma 5
Version: 5.3.0.0.alpha0+
Build ID: f3d26af51588af441f62fb69bb7a5432845226ac
CPU Threads: 8; OS Version: Linux 4.6; UI Render: default; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on August 5th 2016
Comment 2 Yotam Benshalom 2016-08-07 17:36:55 UTC
I checked this, and using SAL_RTL_ENABLED=1 is not equivalent to actually running writer in RTL locale and with an RTL UI with regards to the pulldown buttons. 
To reproduce the bug you need to set the locale and the interface to an rtl language, such as Hebrew.
Comment 3 Yotam Benshalom 2016-08-07 17:50:44 UTC
Also, I saw you use KDE, and this bug may be related to the GTK3 rendering.
Comment 4 Buovjaga 2016-08-08 16:49:17 UTC
Now I tried with Hebrew, but still no problem.
In my first try as well, I used SAL_USE_VCLPLUGIN=gtk3 libreoffice to ensure GTK3 backend was used.

Yotam: is this thing new in 5.2 or was it the case already in 5.1.5?
Which Ubuntu are you using?
Which icon theme and which version of it are you using?

Arch Linux 64-bit, KDE Plasma 5
גרסה: 5.2.0.4
מזהה הבנייה: 5.2.0-2
תהליכי משנה במעבד: 8; גרסת מערכת ההפעלה: Linux 4.6; עיבוד מנשק: בררת מחדל; 
מיקום: he-IL (fi_FI.UTF-8)

גרסה: 5.2.0.4
מזהה הבנייה: 1:5.2.0~rc4-0ubuntu1~xenial1
תהליכי משנה במעבד: 4; גרסת מערכת ההפעלה: Linux 4.4; עיבוד מנשק: בררת מחדל; 
מיקום: he-IL (en_US.UTF-8)
Comment 5 Yotam Benshalom 2016-08-08 19:08:49 UTC
Thanks! This problem also exists in 1:5.1.4-0ubuntu1.
It exists with all installed LibreOffice icon themes: Human, Breeze, Galaxy and Tango.
Gtk controls theme is "Ambiance", a dark theme, and - hooray - the problem disappears when I change it to a light theme like "Adwaita", "Radiance", "Numix" and "HighContrast". So this seems to be an issue with dark themes only. It happens with ltr interface as well, so I change the description of the bug.
Comment 6 Aron Budea 2016-08-14 05:34:09 UTC
Created attachment 126824 [details]
Writer screenshot

This is what my toolbar looks like after installing libreoffice-gtk3 (LibreOffice 5.1.4.2, shipped by Ubuntu).

I like how Adolfo handles GTK3 bugs, eg. here: bug 101395. ;)
Also, the screenshot in bug 98919 shows a lot of similarities with mine, except that in my case the pulldown buttons aren't visible.

So, that's a confirmation, but how shall we proceed?
Comment 7 Buovjaga 2016-08-14 11:29:17 UTC
Pinging Björn: thoughts on this report and comment 6?
Comment 8 Yotam Benshalom 2016-09-10 10:16:22 UTC
Bug is resolved for me in 5.2.2 rc1 using Ambiance theme in ubuntu 16.10. I do not know if the problem was in Libreoffice or in the theme, but the problem is gone.
Comment 9 Aron Budea 2016-09-10 17:18:00 UTC
Thanks for the update!
Adjusting status to WORKSFORME, since the commit fixing the issue is unknown.