| Summary: | Removal of tooltip_markup properties from glade ui files | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Yousuf Philips (jay) (retired) <philipz85> |
| Component: | UI | Assignee: | Muhammet Kara <kara> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bubli, caolan.mcnamara, kara, mentoring, samuel.mehrbrodt |
| Priority: | medium | Keywords: | easyHack, skillUI, topicCleanup, topicUI |
| Version: | 5.3.0.0.alpha0+ | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=102784 | ||
| Whiteboard: | target:5.3.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: | formatted tooltip_markup screenshot | ||
|
Description
Yousuf Philips (jay) (retired)
2016-08-16 07:04:17 UTC
+1 for removing them, especially if they're identical An easy hack The script should be committed to core/bin So is it enough just to remove the lines containing "tooltip_markup" property from .ui files? Or should we also check if they have values identical to the corresponding tooltip_text? These are the files I have processed with a bash script so far: modified: chart2/uiconfig/ui/tp_3D_SceneIllumination.ui modified: chart2/uiconfig/ui/tp_RangeChooser.ui modified: cui/uiconfig/ui/lineendstabpage.ui modified: cui/uiconfig/ui/linestyletabpage.ui modified: cui/uiconfig/ui/numberingformatpage.ui modified: cui/uiconfig/ui/rotationtabpage.ui modified: cui/uiconfig/ui/textanimtabpage.ui modified: fpicker/uiconfig/ui/explorerfiledialog.ui modified: fpicker/uiconfig/ui/remotefilesdialog.ui modified: sc/uiconfig/scalc/ui/datastreams.ui modified: sc/uiconfig/scalc/ui/headerfootercontent.ui modified: sc/uiconfig/scalc/ui/notebookbar.ui modified: sc/uiconfig/scalc/ui/optcalculatepage.ui modified: sc/uiconfig/scalc/ui/pastespecial.ui modified: sc/uiconfig/scalc/ui/sidebaralignment.ui modified: sc/uiconfig/scalc/ui/sidebarcellappearance.ui modified: sc/uiconfig/scalc/ui/sidebarnumberformat.ui modified: sc/uiconfig/scalc/ui/solverdlg.ui modified: sc/uiconfig/scalc/ui/xmlsourcedialog.ui modified: sd/uiconfig/simpress/ui/customanimationspanelhorizontal.ui modified: sd/uiconfig/simpress/ui/customanimationtimingtab.ui modified: sd/uiconfig/simpress/ui/photoalbum.ui modified: sd/uiconfig/simpress/ui/slidetransitionspanel.ui modified: sd/uiconfig/simpress/ui/slidetransitionspanelhorizontal.ui modified: svx/uiconfig/ui/redlinefilterpage.ui modified: svx/uiconfig/ui/sidebararea.ui modified: svx/uiconfig/ui/sidebargraphic.ui modified: svx/uiconfig/ui/sidebarline.ui modified: svx/uiconfig/ui/sidebarpossize.ui modified: sw/uiconfig/swriter/ui/addressblockdialog.ui modified: sw/uiconfig/swriter/ui/cardmediumpage.ui modified: sw/uiconfig/swriter/ui/envaddresspage.ui modified: sw/uiconfig/swriter/ui/fldvarpage.ui modified: sw/uiconfig/swriter/ui/tocentriespage.ui Created attachment 127706 [details] formatted tooltip_markup screenshot So the code first pulls from tooltip_markup and then tooltip_text, so the checking should only check to confirm that a tooltip_text entry is available and then remove tooltip_markup, but if tooltip_text isnt available, it should rename tooltip_markup to tooltip_text. tooltip_markup uses pango text markup, but we dont seem to support formatted tooltips when i tested it in the notebookbark. https://developer.gnome.org/pango/stable/PangoMarkupFormat.html Code reference: http://opengrok.libreoffice.org/xref/core/vcl/source/window/builder.cxx#2743 Muhammet Kara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=652c97b8216c03676bbee08f749e2164e8808c8d tdf#101549: Remove tooltip_markup from glade .ui files It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Seems solved (as pr IRC) Muhammet Kara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=c9196b4996377eecba6c06cd916f0e2268c1933d tdf#101549: Add script to remove tooltip_markups It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |