| Summary: | Delete Contents dialog -- won't delete cell content "Date & time" | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Alexis PAQUIN <chpaqou> |
| Component: | Calc | Assignee: | Jean-Sebastien Bevilacqua <realitix> |
| Status: | VERIFIED FIXED | ||
| Severity: | minor | CC: | chpaqou, erack, raal, vsfoote, xiscofauli |
| Priority: | medium | Keywords: | bibisected, regression |
| Version: | 4.2 all versions | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:5.4.0 target:5.3.2 target:6.2.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: | Delete cell content Date | ||
Did not check how far back the issue exists, but confirming.
Here are a bit better STR rather than selecting all.
Open attachment 127155 [details]
Select the two cells with dates A1 & C1
Context menu -> Clear Contents to open
Delete Contents dialog
uncheck all
check Date & Time
OK to apply
Expected -- the Dates selected are cleared
Actual -- the Dates are not changed
Selecting "Numbers" on the Delete Contents dialog clears the cells--so either the cells are not recognized as holding dates (even though they format as dates), or the Delete Contents dialog has faulty logic.
Hey, Before commit the fix, i can tell you that the Date & Time cells aren't recognized during delete contents. To fix it, i add a boolean to identify the Date & Time cells. The Delete contents dialog is good. Do you want the class source file ? Best regards. Alexis Patches are welcome for review, or better commit back to git repo and post the gerrit link here. There here is c: https://gerrit.libreoffice.org/#/c/28691/ Hey, The patche seem good now. Don't we have to test it in an other way ? And in witch version of LO this patche will be releas ? Best regards The patch is not good, please see comment there of Nov-15 (In reply to Eike Rathke from comment #6) > The patch is not good, please see comment there of Nov-15 Oh yes ! sorry for forgetting that . I'm looking for fix it Hi, I added a patch that fixes this bug: https://gerrit.libreoffice.org/#/c/34068/ Alexi Paquin is not working on it anymore so I have done the job. Jean-Sebastien Bevilacqua committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=4575d7cf657ae291c427c2318eb4600cec2f12b7 tdf#101904 Fix Date deleting in SCalc It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Jean-Sebastien Bevilacqua committed a patch related to this issue. It has been pushed to "libreoffice-5-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=3e4db9f12046255dbcd968b28c670cb83cf83418&h=libreoffice-5-3 tdf#101904 Fix Date deleting in SCalc It will be available in 5.3.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Zdeněk Crhonek committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=681b3facd3ddb7ab4577c48e232fb29a269d0d40 uitest ProtectSheet, protectSpreadsheet, clearCells, tdf#101904 It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. its working date cells are deleted Version: 6.2.0.0.alpha0+ Build ID: a1f5b1f30a5a80d7eeed2efe2564763bf1d12086 CPU threads: 8; OS: Linux 4.14; UI render: default; VCL: gtk3; Locale: nl-BE (en_US.UTF-8); Calc: group threaded The test exist, set status to Verified. |
Created attachment 127155 [details] Delete cell content Date Hey, Since LO 4.2, we can't delete cell content Date. With the attached file, select all cells, use "Sheet - Clear Cells", chose "Date & Time" and then OK. Result Date cells aren't delete. I find an easy fix. In fact, since LO 4.2 the Date cell type disappear. I will try to commit this fix and add the commit number. Best reagards.