Bug 102230

Summary:	Paragraph Style unable to apply underlining Font Effects
Product:	LibreOffice	Reporter:	marshals <simon.marshall>
Component:	Writer	Assignee:	Not Assigned <libreoffice-bugs>
Status:	RESOLVED DUPLICATE
Severity:	normal	CC:	libreoffice-ux-advise, vsfoote
Priority:	medium
Version:	3.6.0.4 release
Hardware:	All
OS:	All
Whiteboard:
Crash report or crash signature:		Regression By:
Attachments:	document to use for reproducing the bug

Description marshals 2016-09-16 15:07:10 UTC

Created attachment 127369 [details]
document to use for reproducing the bug

I was asked to move this from the partially fixed https://bugs.documentfoundation.org/show_bug.cgi?id=66152 as a separate issue

It still applies to LO-5.2.1.2 (x64) on Win-10 Home-64

- open the attached document
- right-click on line 4 (the header "Similarities")
- from popup menu, chose "Edit Style..."
- select "Font Effects" tab in "Paragraph Stype: Heading 2" window
- change "Overlining" from "(Without)" to "Single" and click "Apply"
- overlining appears in the Paragraph Style window preview and the corresponding Header 2 text in the document.  Yay!
- change "Strikethrough" from "(Without)" to "Single" and click "Apply"
- strikethrough appears in the Paragraph Style window preview and the corresponding Header 2 text in the document.  Yay!
- change "Underlining" from "(Without)" to "Single" and click "Apply"
- underlining appears in the Paragraph Style window preview but NOT the corresponding Header 2 text in the document.  This is a bug.
Interestingly...
- click on "OK" in the "Paragraph Stype: Heading 2" window
- right-click on line 4 (the header "Similarities")
- from popup menu, chose "Edit Paragraph Style..."
- select "Font Effects" tab in "Paragraph Stype: Heading 2" window
... you can see that the dropdown menu and preview still show the paragraph style has underlining turned on, but however much you try you can't get it to display underlining in the document.

Comment 1 V Stuart Foote 2016-09-16 15:41:08 UTC

Confirming on Windows 10 Pro 64-bit en-US with
Version: 5.2.1.2 (x64)
Build ID: 31dd62db80d4e60af04904455ec9c9219178d620
CPU Threads: 8; OS Version: Windows 6.19; UI Render: GL; 
Locale: en-US (en_US); Calc: group

None of the Underlining Font Effects from the Paragraph Style dialog apply to text on document canvas, although the show in the preview panel on the dialog.

Comment 2 Octavio Alvarez 2016-09-17 06:50:10 UTC

Strictly speaking, I can't reproduce this.

The problem is that this document has a direct "do not underline" formatting applied.

After performing the steps to reproduce, and indeed, failing for the underlining to appear on the Heading 2, do Ctrl+A, Ctrl+M and the underline appears.

It also works if Ctrl+A and Ctrl+M is done before the steps to reproduce: the misbehavior does not occur.

This also doesn't happen on a clean document.

Ctrl+A selects all text and Ctrl+M is the equivalent of "Clear Direct Formatting".

My guess is that the user intended to "unapply underline as direct-format" by deselecting "U" from the toolbar and Writer did "apply no-underline as direct-format" instead, leading to an overridden style format. This direct format gets removed when doing Ctrl+M and now everything works as expected.

Take a look at comment 13 on bug #89960 [1] and comment 1 on bug #89960 [2] where I describe this as the "hidden DF trap".

[1] https://bugs.documentfoundation.org/show_bug.cgi?id=83726#c13
[2] https://bugs.documentfoundation.org/show_bug.cgi?id=89960#c1

My suggestion is for this bug to be closed as duplicate of #89960.

Tested on Debian/Sid with LibO 5.1.3.1.

Comment 3 V Stuart Foote 2016-09-17 11:55:07 UTC

(In reply to Octavio Alvarez from comment #2)
> 
> The problem is that this document has a direct "do not underline" formatting
> applied.
> 

> [1] https://bugs.documentfoundation.org/show_bug.cgi?id=83726#c13
> [2] https://bugs.documentfoundation.org/show_bug.cgi?id=89960#c1
> 
> My suggestion is for this bug to be closed as duplicate of #89960.

Sorry, I missed that direct formatting was present and was only using the Edit Style dialog process. Opening the test document ODF archive, within the content.xml, both the Heading_20_2 and derived P7 have "text-underline-style=none" direct formatting (DF) applied.

Using Find & Replace: Paragraph Styles mode, and removing the DF with <Ctrl>+M for each Heading2 based paragraph permits the Edit Style changes to underline assert.

Agree this demonstrates a clear Direct Formatting trap as addressed for enhancement in bug 89960 -- NOTABUG but closing as duplicate for needed UX attention.

*** This bug has been marked as a duplicate of bug 89960 ***