| Summary: | FILESAVE: Language set for portions of text lost after saving | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | pierre-yves samyn <pierre-yves.samyn> |
| Component: | Calc | Assignee: | Eike Rathke <erack> |
| Status: | CLOSED FIXED | ||
| Severity: | normal | CC: | erack, markus.mohrhard |
| Priority: | medium | Keywords: | regression |
| Version: | 4.2 all versions | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:5.3.0 target:5.2.4 | ||
| Crash report or crash signature: | Regression By: | ||
|
Description
pierre-yves samyn
2016-09-22 09:52:24 UTC
Confirmed, but removing regression keyword (or compared to which version this is a regression? Did it ever work?). Hi (In reply to Eike Rathke from comment #1) > Confirmed, Thank you >but removing regression keyword (or compared to which version > this is a regression? Did it ever work?). As this action seems strange to me! 1. Why would I added this keyword (which is not selected by default) without knowing that it is a regression? 2. Why remove without knowing? NEED INFO would have been enough. I feel bad considered. Whatever... I did not have means to specify the regression when I submitted this report. I can now specify a little: - was ok since OOo to 4.1.0.2 (windows) - was not ok with Version: 4.2.0.1 Build ID: 7bf567613a536ded11709b952950c9e8f7181a4a HTH Best Regards @Eike: So this is an import problem. The problem is in LanguageTag::convertToLanguageType where we check that rLocale.Language.isEmpty() and return the system locale in that case. However it seems that we only have:
aLocale
$10 = {Language = "", Country = "DE", Variant = ""}
Does it make sense if only Country is set?
No, that doesn't make sense at all. Actually it's not an import problem, <style:style style:name="T1" style:family="text"> is written with <style:text-properties fo:country="DE"> but no fo:language. I'm trying to wade my way through export to find the culprit that's not using SvXMLExport::AddLanguageTagAttributes() to write.. Respectively not all XMLPropertyHandler derived XMLCharLanguageHdl, XMLCharScriptHdl, XMLCharCountryHdl and XMLCharRfcLanguageTagHdl. Eike Rathke committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=c3f096c7630994450625307091a0e6009fb02bc4 Resolves: tdf#102357 export correct locale attribution, not just country It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Eike Rathke committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=27466acb4eda3ec6432d575091effe6c3a780950 pamper over-pessimistic whining compilers, tdf#102357 follow-up It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Pending review https://gerrit.libreoffice.org/29986 for 5-2 Eike Rathke committed a patch related to this issue. It has been pushed to "libreoffice-5-2": http://cgit.freedesktop.org/libreoffice/core/commit/?id=46ecb53fe18acef193314306355252363fe76ff9&h=libreoffice-5-2 Resolves: tdf#102357 export correct locale attribution, not just country It will be available in 5.2.4. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Hi Verified on windows 7/64 & Version: 5.3.0.0.alpha1+ Build ID: 8a796410ec8f440b4163b15b928347c499da7a8f CPU Threads: 2; OS Version: Windows 6.1; UI Render: default; TinderBox: Win-x86@42, Branch:master, Time: 2016-10-20_23:07:21 Locale: fr-FR (fr_FR); Calc: group Fast and efficient, thank you! Regards Pierre-Yves |