Bug 103233

Summary: Button state is not respected
Product: LibreOffice Reporter: Heiko Tietze <heiko.tietze>
Component: UIAssignee: Not Assigned <libreoffice-bugs>
Status: RESOLVED INVALID    
Severity: trivial CC: glogow, ilmari.lauhakangas, thb
Priority: low    
Version: 5.3.0.0.alpha0+   
Hardware: All   
OS: Linux (All)   
Whiteboard: kde4
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 102495    
Attachments: Highlight when clicking save button

Description Heiko Tietze 2016-10-15 09:08:54 UTC 
Push buttons such as Ok, Cancel have a feeback when pressed by changing the color to blue in case of Breeze. However, LibreOffice makes the button gray. 
Tabbing through a dialog works as expected and lets the button shine (same blue highlight).

Tested under LXQt with Kwin, Breeze Dark.

Version: 5.3.0.0.alpha0+
Build ID: d2081e8b61bbe982f4e0977c2b46e00ccf19732f
CPU Threads: 8; OS Version: Linux 4.7; UI Render: default; 
Locale: en-US (en_US.UTF-8); Calc: group

Compiled for source using
--without-java
--without-help
--without-myspell-dicts
--without-doxygen
--without-system-postgresql
--disable-gtk3
--disable-postgresql-sdbc
--enable-kde4
--disable-firebird-sdbc
--disable-dbus
--disable-cups
Comment 1 Buovjaga 2016-10-28 18:37:46 UTC 
Created attachment 128329 [details]
Highlight when clicking save button

Is this wrong or right?

Arch Linux 64-bit, KDE Plasma 5
Version: 5.3.0.0.alpha1+
Build ID: 6dc8f25ecf676a2e4d1a1018b729fef4096df8e7
CPU Threads: 8; OS Version: Linux 4.8; UI Render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on October 28th 2016
Comment 2 Buovjaga 2016-10-28 18:49:33 UTC 
Ah, I see the grayness:
1. Try to close unsaved document
2. Click Don't save or cancel.

Arch Linux 64-bit, KDE Plasma 5
Version: 5.3.0.0.alpha1+
Build ID: 6dc8f25ecf676a2e4d1a1018b729fef4096df8e7
CPU Threads: 8; OS Version: Linux 4.8; UI Render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on October 28th 2016
Comment 3 Heiko Tietze 2016-10-28 19:37:50 UTC 
(In reply to Buovjaga from comment #1)
> Is this wrong or right?

Depends on the configuration. The plasmathemeexplorer shows how it has to look, more or less.

http://notmart.org/blog/2015/04/plasma-theme-explorer/
https://www.archlinux.org/packages/extra/i686/plasma-sdk/files/
Comment 4 QA Administrators 2017-10-29 13:05:06 UTC Comment hidden (obsolete)
Comment 5 Buovjaga 2019-01-01 19:08:09 UTC 
Still gray with the new kde5 backend.

Arch Linux 64-bit
Version: 6.3.0.0.alpha0+
Build ID: 2c7b0030b40de00e8c9ab997bdfe83631861968a
CPU threads: 8; OS: Linux 4.20; UI render: default; VCL: kde5; 
Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US
Calc: threaded
Built on 1 January 2019
Comment 6 Jan-Marek Glogowski 2019-06-13 16:34:46 UTC 
(In reply to Buovjaga from comment #5)
> Still gray with the new kde5 backend.

For me it's gray too, but that's IMHO correct. Or you describe a different bug.

There is a difference between the focus handling for KDE and LO, which is eventually a usability question … or not.

Take the "close unsaved document" dialog from kate and LO.

1. click and hold the left mouse button on a button, which currently *doesn't* have the focus
2. move the mouse a bit (seems to be required here)

LO: won't switch focus
KDE: will switch focus

As a result in LO + KDE breeze, the button is gray in LO, but light blue in kate.

If you see something else, then please describe exactly what you're doing. Otherwise close the bug as INVALID.

Now gtk3 seems to fake the focus, even if it's not switched from LO point of view. LO can do this with kde5 too, but I'm not sure LO should.
Comment 7 Buovjaga 2019-06-13 18:43:50 UTC 
I believe you, so I will close