Bug 103779

Summary:	Help menu accessibility
Product:	LibreOffice Online	Reporter:	Aleksander Machniak <machniak>
Component:	LibreOffice	Assignee:	Henry Castro <hcastro>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kendy, timar74, xiscofauli
Priority:	medium
Version:	unspecified
Hardware:	All
OS:	All
Whiteboard:	target:5.4.0 target:5.3.0.4
Crash report or crash signature:		Regression By:

Description Aleksander Machniak 2016-11-08 11:09:17 UTC

Most of the menu actions do not steal focus from the document, i.e. it is possible to continue using keyboard immediately (without a need to click it first). However, there are some actions that do not re-focus the document.

1. Help > About.
2. Help > Keyboard shortcuts.

Also, these dialogs should receive focus on opening to allow closing them with Esc button.

And bonus points for creating a keyboard shortcut to display the Keyboard shortcuts help and for allowing to scroll the dialog with arrow keys (just needs focus on the dialog).

Comment 1 Olivier Hallot 2016-11-08 12:45:45 UTC

Verified

LOOLWSD
1.9.0 (git hash: 7b83a5f)

LOKit
Collabora Office 5.1-11 (git hash: 646762e)

Comment 2 Commit Notification 2016-12-22 17:41:48 UTC

Henry Castro committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/online/commit/?id=1bede62b132e61fa847aaf066447c2670d14dbab

tdf#103779: Help menu accessibility

Comment 3 Andras Timar 2017-01-06 11:14:03 UTC

Fixed mostly, this is still outstanding:

"And bonus points for creating a keyboard shortcut to display the Keyboard shortcuts help and for allowing to scroll the dialog with arrow keys (just needs focus on the dialog)."

Comment 4 Commit Notification 2017-01-07 03:13:26 UTC

Henry Castro committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/online/commit/?id=73cf6f71fbe1ccb1946958b06e8deab16176a82c

tdf#103779: Help menu accessibility, part 2

Comment 5 Henry Castro 2017-01-07 12:10:54 UTC

any suggestion, to change the shortcut ctrl + H?

Comment 6 Aleksander Machniak 2017-01-07 12:19:25 UTC

Github uses Ctrl + Shift + ? for keyboard shortcuts help.

Comment 7 Commit Notification 2017-01-07 13:33:12 UTC

Henry Castro committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/online/commit/?id=e1b7e53b3a6f006eec5728c3ec88079c34b4f3c6

tdf#103779: Help menu accessibility, part 3

Comment 8 Xisco Faulí 2017-03-01 11:00:30 UTC

Hello Henry,
Is this bug fixed?
If so, could you please close it as RESOLVED FIXED?

Comment 9 Commit Notification 2017-03-27 01:23:50 UTC

Henry Castro committed a patch related to this issue.
It has been pushed to "libreoffice-5-3":

http://cgit.freedesktop.org/libreoffice/online/commit/?id=2371a82381ef1e6ab6826dd81e26afc5f39e8b0d&h=libreoffice-5-3

tdf#103779: Help menu accessibility