| Summary: | Crash in Calc when selecting "Uniform Integer" with an max value "100000000000000" in "Random Number Generator | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Thomas Hackert <thackert> |
| Component: | Calc | Assignee: | Tomaz Vajngerl <quikee> |
| Status: | VERIFIED FIXED | ||
| Severity: | critical | CC: | aron.budea, miguelangelrv, quikee, raal, serval2412, xiscofauli |
| Priority: | highest | Keywords: | bibisected, bisected, haveBacktrace, regression |
| Version: | 5.0 all versions | ||
| Hardware: | All | ||
| OS: | Linux (All) | ||
| Whiteboard: | target:5.4.0 target:5.3.2 target:5.2.7 target:6.2.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: |
bzip'ed "soffice --backtrace" output
bzip2'ed "soffice --strace" output minimal test cpp file. |
||
|
Description
Thomas Hackert
2016-11-22 15:40:53 UTC
Created attachment 128949 [details]
bzip'ed "soffice --backtrace" output
Created attachment 128950 [details]
bzip2'ed "soffice --strace" output
Not repro on Windows. Version: 5.2.3.3 (x64) Build ID: d54a8868f08a7b39642414cf2c8ef2f228f780cf CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; Locale: es-ES (es_ES); Calc: group Confirmed with v5.2.3.3 under ubuntu 16.04 x64. Confirmed with Version: 5.3.0.0.alpha1+ Build ID: 43b5ca69aa545cf93eded55258d92d651917815f CPU Threads: 2; OS Version: Linux 4.4; UI Render: default; VCL: gtk2; Layout Engine: new; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2016-11-18_05:17:53 Locale: en-US (en_US.UTF-8); Calc: single Notice that tabbing 'max', the value doesn't beyond 9223372036854775807 anyway. According to http://opengrok.libreoffice.org/xref/core/sc/source/ui/StatisticsDialogs/RandomNumberGeneratorDialog.cxx#226, we expect int parameters. But it's obviously not the case here. Perhaps should we check parameters are not greater than SAL_MAX_INT32 or SAL_MAX_INT16 ? Hi, I am able to reproduce this crash with following setup, Version: 5.4.0.0.alpha0+ Build ID: a76ec55964e85a2567505b38e95c5bb9da7988ff CPU Threads: 8; OS Version: Linux 4.8; UI Render: default; VCL: gtk3; Layout Engine: new; Locale: en-US (en_US.utf8); Calc: group Any help or ideas to solve this bug would be appreciated. Thank you. Yogesh Desai Regression introduced by: author Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk> 2015-01-26 06:29:38 (GMT) committer Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk> 2015-01-26 06:32:03 (GMT) commit 26ad60aec69310fecd918f1c2e09056aa4782320 (patch) tree 88798b80d2351f09446a602502717aa3e95d875d parent eef0c5bf210635fe3edbe1ba58b73639fef4bc4b (diff) convert to use std random instead of boost Adding Cc: to Tomaž Vajngerl Created attachment 131568 [details]
minimal test cpp file.
Compiling and executing this code causes segmentation fault. It appears that std::uniform_int_distribution can't handle 64-bit integer range. 32-bit range is okay.
Seems the solution is quite simple then: https://gerrit.libreoffice.org/#/c/34777/ Tomaž Vajngerl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=23672df737258391bd9533e61733c6cc70b9a5eb tdf#104117 set template parameter sal_Int64 for random It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. I'll assign this to you. Tomaz. Hi Tomaz, Thanks for fixing this. I can no longer reproduce it in Version: 5.4.0.0.alpha0+ Build ID: 27c5268dd9908b749ca251e172944278d761a335 CPU threads: 4; OS: Linux 4.8; UI render: default; VCL: gtk2; Locale: ca-ES (ca_ES.UTF-8); Calc: group. You should close it as RESOLVED FIXED Backports for LO 5.3 and 5.2: https://gerrit.libreoffice.org/#/c/34817/ https://gerrit.libreoffice.org/#/c/34818/ Tomaž Vajngerl committed a patch related to this issue. It has been pushed to "libreoffice-5-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=c713f227cc34b841c06beca2e9eaa96653eac372&h=libreoffice-5-3 tdf#104117 set template parameter sal_Int64 for random It will be available in 5.3.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Tomaž Vajngerl committed a patch related to this issue. It has been pushed to "libreoffice-5-2": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a5a2c9c83da3a3cc01a9262d6c659c99ad58b152&h=libreoffice-5-2 tdf#104117 set template parameter sal_Int64 for random It will be available in 5.2.7. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Zdeněk Crhonek committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f5af8615e40bca1a747695c8ca28675c4ab0d384 uitest for bug tdf#104117 and tdf#80693 It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. The test exist, set status to Verified. |