| Summary: | UI: OpenGL Unreadable Menus have black text on black background | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Luke <lukebenes> |
| Component: | UI | Assignee: | David Tardon <dtardon> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aron.budea, dtardon, golzio, mdxrana1, tyrantilles, vsfoote, xiscofauli |
| Priority: | high | Keywords: | bibisected, bisected, regression |
| Version: | 5.3.0.0.alpha1+ | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:5.4.0 target:5.3.0.1 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 93529 | ||
|
Description
Luke
2016-11-24 10:28:38 UTC
Thanks for opening the bug report and bibisecting it. I reported this issue here (turns out it was unrelated to bug 103820): https://bugs.documentfoundation.org/show_bug.cgi?id=103820#c4 Still reproduced in 5.3beta1 / Windows 7. Undoing this commit gets rid of the issue: https://cgit.freedesktop.org/libreoffice/core/commit/?id=7983c946229d580ec825edbde765381035ae02f6 "start with a defined state" Adding Cc: to David Tardon. I cannot reproduce this, but I have reverted a part of the patch, which should hopefully fix the problem. David Tardon committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=83288089d5efd2cd1d5c76b05a4ba3f782641e88 tdf#104139 keep the current OpenGL state It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. David, Thank you! This fixed the menu issue. It also appeared to fix a regression with the slideshow where the first side would appear behind the main Impress app. I could reproduce these issues on both my laptop with Intel HD 5000 and my desktop with a Nvidia 650 in Windows 10. So this may have been a Windows specific bug. Thanks for fixing it. -Luke Did you mean to leave the
{
}
In the commit? Also can you please backport this to 5.3?
(In reply to Luke from comment #6) > Did you mean to leave the > { > > } > > In the commit? Of course. The code would be invalid without them. > Also can you please backport this to 5.3? Yes, I can. I waited for confirmation that it actually fixes the problem. David Tardon committed a patch related to this issue. It has been pushed to "libreoffice-5-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=b53f04662eb7760bb25bb8c6ae97adef0b3fba1b&h=libreoffice-5-3 tdf#104139 keep the current OpenGL state It will be available in 5.3.0.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Tomaž Vajngerl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=58a6cbfbf309b151b9d1463c734343430f9a1220 tdf#104139 state can't be set as context may not be available It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Tomaž Vajngerl committed a patch related to this issue. It has been pushed to "libreoffice-5-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=959bf134acb2782f4bf2ab299a96581e016ebc3d&h=libreoffice-5-3 tdf#104139 state can't be set as context may not be available It will be available in 5.3.0.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. *** Bug 104358 has been marked as a duplicate of this bug. *** *** Bug 104352 has been marked as a duplicate of this bug. *** *** Bug 104525 has been marked as a duplicate of this bug. *** |