Bug 104382

Summary:	Menus should be disabled when they have no enabled submenus
Product:	LibreOffice	Reporter:	Tamás Zolnai <zolnaitamas2000>
Component:	UI	Assignee:	Balázs Varga (allotropia) <balazs.varga991>
Status:	VERIFIED FIXED
Severity:	trivial	CC:	79045_79045, aron.budea, dgp-mail, ilmari.lauhakangas, jean-philippe.mengual, kainz.a, patrick, TorrAB
Priority:	low	Keywords:	accessibility
Version:	5.4.0.0.alpha0+
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=156496 https://bugs.documentfoundation.org/show_bug.cgi?id=156497 https://bugs.documentfoundation.org/show_bug.cgi?id=156498
Whiteboard:	target:24.2.0
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	85811, 101912

Description Tamás Zolnai 2016-12-03 18:37:22 UTC

Description:
Menus with submenus are always enabled, but when they have all submenus disabled the menu also should be disabled.
I think this is true for all kind of this menus. An example is the Table menus in Writer (Table -> Insert, Table -> Delete).
It a UI problem: user can think table insertion or deletion is available, but it's not.
Also an accessibility problem. An accessibility tool should skip (not read) those menus which are not available in the current context.

Steps to Reproduce:
1.Open an empty document in Writer
2.Select Table menu
3.You can see Table -> Insert, Table -> Delete menus are enabled, but they have no availabla submenus, so no reason to be enabled.

Actual Results:  
Menus are enabled when actually their submenus are disabled all.

Expected Results:
These menus should be disabled, when their functionality is not available.


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.100 Safari/537.36

Comment 1 Buovjaga 2016-12-09 15:23:24 UTC

Sounds logical -> NEW

Comment 2 QA Administrators 2017-12-10 16:43:18 UTC Comment hidden (obsolete)

** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not
appropriate in this case)

If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword

Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

Comment 3 Roman Kuznetsov 2018-12-14 20:29:18 UTC

still repro in

Version: 6.3.0.0.alpha0+
Build ID: 3c964980da07892a02d5ac721d80558c459532d0
CPU threads: 4; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-12-12_02:07:45
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: threaded

but we should have full list of that menu items

Comment 4 Roman Kuznetsov 2019-04-11 09:16:24 UTC

*** Bug 124674 has been marked as a duplicate of this bug. ***

Comment 5 Buovjaga 2022-05-20 13:07:44 UTC

*** Bug 144127 has been marked as a duplicate of this bug. ***

Comment 6 Commit Notification 2023-07-28 07:23:52 UTC

Balazs Varga committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/630303ad8e94bd634b98e691935a1f4c19582a3a

tdf#104382 - Menus should be disabled when they have no enabled submenus

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 7 Roman Kuznetsov 2023-07-29 10:41:13 UTC

Verified in

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: e26aeb882dd236adf19679d5df9b7ba5da1ed226
CPU threads: 16; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: CL threaded

Balazs, thank you for the patch!