Bug 104545

Summary:	Edit page-break dropdown between pages uses current cursor placement - not first paragraph of following page
Product:	LibreOffice	Reporter:	Justin L <jluth>
Component:	Writer	Assignee:	Justin L <jluth>
Status:	VERIFIED FIXED
Severity:	normal	CC:	Armin.Le.Grand, jluth, xiscofauli
Priority:	medium	Keywords:	bibisected, bisected, regression
Version:	4.4.0.3 release
Hardware:	All
OS:	All
Whiteboard:	target:5.4.0 target:5.3.0.1 target:5.2.5
Crash report or crash signature:		Regression By:
Attachments:	editBreakCursor.odt: demo with instructions

Description Justin L 2016-12-10 09:02:56 UTC

Created attachment 129445 [details]
editBreakCursor.odt: demo with instructions

using the dropdown UI on the dashed page-break indicator shouldn't respond differently if the cursor location is in different places in the text.

This is a regression in LO 4.4, which linux bibisect44max shows belongs to this duo of sequential commits:
commit c7853b5b5cb71899b6b60fd2175763785b8afb7f
    Author:     Caolán McNamara <caolanm@redhat.com>
    CommitDate: Tue Jul 1 13:30:09 2014 +0200
        hook up new drawing support to .uis

commit 7d9bb549d498d6beed2c4050c402d09643febdfa
    Author:     Armin Le Grand <alg@apache.org>
    CommitDate: Tue Jul 1 13:30:09 2014 +0200
        Related: #i124638# Second step of DrawingLayer FillAttributes...
for Writer objects, now added support for Paragraph and PageStyle (including
Header and Footer) for direct attributes and style attributes

To reproduce, open the attached example document.
-place the cursor in the first paragraph as indicated
-click on the dropdown - edit page break that appears when you hover over the dashed page-break indicator between the two pages.
-look at the area tab - it ought to be showing a blue color, (not none.)
-look at the text flow tab - it ought to be showing a pagebreak with style default (not landscape)

Comment 1 Xisco Faulí 2016-12-11 12:30:19 UTC

Moving it to NEW as the commits that introduced this regression have been identified.

Adding Cc: to Armin Le Grand

Comment 2 Justin L 2016-12-13 11:30:24 UTC

Proposed fix: https://gerrit.libreoffice.org/31953

Comment 3 Commit Notification 2016-12-13 14:26:28 UTC

Justin Luth committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=e08355618e13a83210b746c67bb9f7a0b425e1dc

tdf#104545 SID_PARA_DLG: use passed PaM instead of GetCursor

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 4 Commit Notification 2016-12-14 05:31:29 UTC

Justin Luth committed a patch related to this issue.
It has been pushed to "libreoffice-5-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=496fe48b64e6b395e525852e8494f67f67406148&h=libreoffice-5-3

tdf#104545 SID_PARA_DLG: use passed PaM instead of GetCursor

It will be available in 5.3.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 5 Commit Notification 2016-12-14 10:18:59 UTC

Justin Luth committed a patch related to this issue.
It has been pushed to "libreoffice-5-2":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=533482bbdfe4d96b69aff2e0dcc2101fcc912293&h=libreoffice-5-2

tdf#104545 SID_PARA_DLG: use passed PaM instead of GetCursor

It will be available in 5.2.5.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.