Bug 104615

Summary:	Crash when going into data series/area/bitmap after opening odc
Product:	LibreOffice	Reporter:	Julien Nabet <serval2412>
Component:	Chart	Assignee:	Julien Nabet <serval2412>
Status:	RESOLVED FIXED
Severity:	normal	CC:	xiscofauli
Priority:	medium	Keywords:	haveBacktrace
Version:	5.4.0.0.alpha0+
Hardware:	x86-64 (AMD64)
OS:	Linux (All)
Whiteboard:	target:5.4.0 target:5.3.0.1
Crash report or crash signature:		Regression By:

Description Julien Nabet 2016-12-12 20:14:13 UTC

Description:
On pc Debian x86-64 with master sources updated yesterday, I had a crash when wanting to open directly odc file then going to data series of the charts, then area tab and finally bitmap.

Steps to Reproduce:
1. Open odc file with Calc
2. Double click on column to open Data Series dialog
3. Select Area tab
4. Click Bitmap button

Actual Results:  
Crash

Expected Results:
No crash


Reproducible: Always

User Profile Reset: Yes

Additional Info:
Doesn't crash when opening same chart in a ods file


User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0

Comment 1 Julien Nabet 2016-12-12 20:17:50 UTC

bt part:
Thread 1 "soffice.bin" received signal SIGSEGV, Segmentation fault.
SdrEditView::GetGeoAttrFromMarked (this=0x0) at /home/julien/lo/libreoffice/svx/source/svdraw/svdedtv1.cxx:1278
1278	    SfxItemSet aRetSet(mpModel->GetItemPool(),   // SID_ATTR_TRANSFORM_... from s:svxids.hrc
(gdb) bt
#0  SdrEditView::GetGeoAttrFromMarked (this=0x0) at /home/julien/lo/libreoffice/svx/source/svdraw/svdedtv1.cxx:1278
#1  0x00002aaadf70ae97 in SvxBitmapTabPage::Reset (this=0x55555b2eb8b0, rAttrs=0x55555afa0310) at /home/julien/lo/libreoffice/cui/source/tabpages/tpbitmap.cxx:278
#2  0x00002aaadf702c24 in SvxAreaTabPage::CreatePage (this=this@entry=0x55555b0183b0, nId=nId@entry=4, pTab=0x55555b2eb8b0)
    at /home/julien/lo/libreoffice/cui/source/tabpages/tparea.cxx:411
#3  0x00002aaadf702ff1 in SvxAreaTabPage::SelectFillTypeHdl_Impl (this=0x55555b0183b0, pButton=0x55555b022b70)
    at /home/julien/lo/libreoffice/cui/source/tabpages/tparea.cxx:340
#4  0x00002aaadf70302b in SvxAreaTabPage::LinkStubSelectFillTypeHdl_Impl (instance=<optimized out>, data=<optimized out>)
    at /home/julien/lo/libreoffice/cui/source/tabpages/tparea.cxx:332

Comment 2 Julien Nabet 2016-12-12 20:40:52 UTC

After first fix, second bt:
SdrPaintView::GetModel (this=0x0) at /home/julien/lo/libreoffice/include/svx/svdpntv.hxx:256
256	    SdrModel* GetModel() const { return mpModel; }
(gdb) bt
#0  SdrPaintView::GetModel (this=0x0) at /home/julien/lo/libreoffice/include/svx/svdpntv.hxx:256
#1  0x00002aaadf90ba0f in SvxBitmapTabPage::ModifyBitmapHdl (this=this@entry=0x55555b2e7950) at /home/julien/lo/libreoffice/cui/source/tabpages/tpbitmap.cxx:526
#2  0x00002aaadf90bcc7 in SvxBitmapTabPage::ClickBitmapHdl_Impl (this=this@entry=0x55555b2e7950) at /home/julien/lo/libreoffice/cui/source/tabpages/tpbitmap.cxx:457
#3  0x00002aaadf90c9d8 in SvxBitmapTabPage::Reset (this=0x55555b2e7950, rAttrs=<optimized out>) at /home/julien/lo/libreoffice/cui/source/tabpages/tpbitmap.cxx:441
#4  0x00002aaadf903c24 in SvxAreaTabPage::CreatePage (this=this@entry=0x55555aff01e0, nId=nId@entry=4, pTab=0x55555b2e7950)
    at /home/julien/lo/libreoffice/cui/source/tabpages/tparea.cxx:411
#5  0x00002aaadf903ff1 in SvxAreaTabPage::SelectFillTypeHdl_Impl (this=0x55555aff01e0, pButton=0x55555affdee0)
    at /home/julien/lo/libreoffice/cui/source/tabpages/tparea.cxx:340
#6  0x00002aaadf90402b in SvxAreaTabPage::LinkStubSelectFillTypeHdl_Impl (instance=<optimized out>, data=<optimized out>)
    at /home/julien/lo/libreoffice/cui/source/tabpages/tparea.cxx:332

Comment 3 Xisco Faulí 2016-12-12 20:47:59 UTC

I can't reproduce it opening attachment 95302 [details] in 

Version: 5.4.0.0.alpha0+
Build ID: 634589b340316ba64b731b4d923c1056be415494
CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

Comment 4 Katarina Behrens (Inactive) 2016-12-12 21:51:20 UTC

(In reply to Xisco Faulí from comment #3)
> I can't reproduce it opening attachment 95302 [details] in 
 
You can't, because it's a line chart :) A bar/column or a pie chart, more generally any chart where data points are represented by 2D area (so that area tab is actually present in format data series dialog) reproduces the bug

Try again with changing the chart type

Comment 5 Xisco Faulí 2016-12-12 22:03:27 UTC

no crash even after changing the chart type...

Comment 6 Commit Notification 2016-12-14 12:36:20 UTC

Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=d543d66a4ee34d3b0088f45951b56c150f7206ec

tdf#104615: there's no mpView when opening odc directly

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 7 Commit Notification 2016-12-14 12:53:20 UTC

Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-5-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=b8cb82eaeab9f0f36dc6dae1009d9e97108a90c3&h=libreoffice-5-3

tdf#104615: there's no mpView when opening odc directly

It will be available in 5.3.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.