| Summary: | Crash when closing LibreOffice after opening Master Pages deck in SfxModule::GetResMgr() | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Telesto <telesto> |
| Component: | Impress | Assignee: | Michael Stahl (allotropia) <michael.stahl> |
| Status: | RESOLVED FIXED | ||
| Severity: | critical | CC: | aptitude, michael.stahl, noelgrandin, serval2412, vsfoote, xiscofauli |
| Priority: | highest | Keywords: | bibisected, bisected, regression |
| Version: | 5.3.0.0.beta2 | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | http://crashreport.libreoffice.org/stats/signature/SfxModule::GetResMgr() | ||
| Whiteboard: | target:5.4.0 target:5.3.0.2 | ||
| Crash report or crash signature: | ["SfxModule::GetResMgr()"] | Regression By: | |
| Attachments: | bt with symbols | ||
|
Description
Telesto
2017-01-08 14:40:17 UTC
Confirming with STR listed. On Windows 10 Pro 64-bit en-US with Version: 5.3.0.1 (x64) Build ID: 3b800451b1d0c48045de03b5b3c7bbbac87f20d9 CPU Threads: 8; OS Version: Windows 6.19; UI Render: default; Layout Engine: new; Locale: en-US (en_US); Calc: CL Version: 5.3.0.0.beta2 (x64) Build ID: a7e30712ad6d8bc9286007b37aa581983e0caba3 CPU Threads: 8; OS Version: Windows 6.19; UI Render: GL; Layout Engine: new; Locale: en-US (en_US); Calc: CL stacktrace shows against Crashreport signature SfxModule::GetResMgr() 5.3.0.1 64-bit en-US http://crashreport.libreoffice.org/stats/crash_details/fe7dd781-988c-49a3-a5f7-ecbb089c1380 5.3.0beta2 64-bit en-US http://crashreport.libreoffice.org/stats/crash_details/88dbc276-1e00-44d4-8be1-b79beaeff7a3 Created attachment 130267 [details]
bt with symbols
On pc Debian x86-64 with master sources updated today, I could reproduce this.
Mark/Noel: noticing https://cgit.freedesktop.org/libreoffice/core/commit/?id=f7b1cd66167050afecf487e3d89ea12de74200b5, thought you might be interested in this one. Regression introduced by: author Mark Page <aptitude@btconnect.com> 2016-07-04 16:30:42 (GMT) committer Noel Grandin <noelgrandin@gmail.com> 2016-07-13 06:32:46 (GMT) commit f7b1cd66167050afecf487e3d89ea12de74200b5 (patch) tree 75381b63bb5dca7ed1fa2ff5602064750f46f042 parent 633413a37ee7442cd899db1269fd3ef404efe58a (diff) Moved SfxModule owner to SfxApplication ::GetAppData replaced with SfxApplication::GetModule that now returns SfxModule* SfxModule no longer registers self for ownership instead it is now registered using SfxApplication::SetModule Change-Id: Ifbbe1b2b4c5122da8e643b7926d47878d116c6c8 Reviewed-on: https://gerrit.libreoffice.org/26914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Adding Cc: to Mark Page That was unexpected. I am unsure what is wrong without delving back into the code maybe Noel can provide some insights here...(In reply to aptitude from comment #5) > That was unexpected. I am unsure what is wrong without delving back into the > code @Noel, Do you have any idea why the code is crashing? well that was a subtle change... goes to show that there's no such thing as a risk-free change to destruction order in c++... fixed on master. Michael Stahl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=983ac87793a891855c7d25c42fe795908543716c tdf#105188 sd: fix shutdown crash after accessing master pages It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-5-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=821b9ee9ba4ab13c3525009eb7e6a8fd60176dd7&h=libreoffice-5-3 tdf#105188 sd: fix shutdown crash after accessing master pages It will be available in 5.3.0.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |