| Summary: | FILESSAVE XLS: file size increases to 21mb after re-saving a particular Calc document | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Justin L <jluth> |
| Component: | Calc | Assignee: | Bartosz <gang65> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | gang65, jluth, josarickx, mclean8414, tonn81, xiscofauli, ya |
| Priority: | medium | Keywords: | bibisected, bisected, filter:xls, regression |
| Version: | 5.2.0.0.alpha0+ | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=98106 | ||
| Whiteboard: | target:5.4.0 target:5.3.1 target:5.2.6 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: |
filesizeBug.xls: when saved by LibreOffice 5.2, size grows to 20MB
Original .xlsx file which cause issues with LibreOffice 00-PRS-Orientation.xls: original, complex sample document Minimal .xlsx file with zeroHeight parameter which is causing dramatically increasing size |
||
|
Description
Justin L
2017-02-07 18:17:12 UTC
Regression introduced by: author Bartosz Kosiorek <gang65@poczta.onet.pl> 2016-06-17 14:21:06 (GMT) committer Markus Mohrhard <markus.mohrhard@googlemail.com> 2016-06-22 23:04:47 (GMT) commit 228c25fd17727660a3372307e3f73dbcff5e71d2 (patch) tree 9ba8688e731c96677288236d1d3dacf4ba29aaae parent 92cee94a262a3a2f43c87bb940c50cb90a2ebd89 (diff) tdf#98106 Preserving hidden and empty rows after xlsx export Adding Cc: to Bartosz Kosiorek Does this bug is reproducible with .xlsx format? If yes please attach it to bug report. fixable by comparing hidden to the previous row, something like ( bHidden != rDoc.RowHidden(nFrom - 1, nScTab) ) || Perhaps that also needs to be done with the other items that were recently added? Please, do not change the status to NEEDINFO once it has been confirmed. *** Bug 105716 has been marked as a duplicate of this bug. *** Created attachment 131008 [details]
Original .xlsx file which cause issues with LibreOffice
In attached files, all columns are hidden by default:
<cols>
<col min="1" max="16384" width="0" style="1" hidden="1" />
</cols>
Calc is not recognize it and is trying to save all rows, even if it is empty.
I created initial review how I would like to resolve it: https://gerrit.libreoffice.org/#/c/34111/ (In reply to Xisco Faulí from comment #1) > Regression introduced by: > tdf#98106 Preserving hidden and empty rows after xlsx export revert tdf#98106 Preserving hidden and empty rows after xlsx export It will be available in 5.2.6. http://cgit.freedesktop.org/libreoffice/core/commit/?id=3e67dc9dbbd802dd82b92304098aaa44e70c014c&h=libreoffice-5-2 Still working with Bartosz on a fix for 5.3, but for 5.2.x series it will just be reverted. Created attachment 131077 [details]
00-PRS-Orientation.xls: original, complex sample document
Created attachment 131081 [details]
Minimal .xlsx file with zeroHeight parameter which is causing dramatically increasing size
Documentation about zeroHeight property: https://msdn.microsoft.com/en-us/library/documentformat.openxml.spreadsheet.sheetformatproperties(v=office.15).aspx *** Bug 105928 has been marked as a duplicate of this bug. *** Justin Luth committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=1cde2eb9d128c9b1b658b1380074461429ab2214 tdf#105840 EXCEL export: fixes for hidden defaultRow It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. @Justin Could you please backport these fix to LO 5.3? Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-5-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=7003415978b162bdd9f84d3e2ea0d05e5599137a&h=libreoffice-5-3 tdf#105840 EXCEL export: fixes for hidden defaultRow It will be available in 5.3.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Well. I think I am to be here again?? I loaded 5.3.0.3. My ods file was OK, looked good, I entered date, time, saved, 3 times, worked good. xls file opened OK, looked good, entered date, time, saved, it took a long time saving, and went from 3.7 to 150.2mb. Opened xls 2 more times, blank. I took screen shots. (In reply to Mark Mclean from comment #17) > Well. I think I am to be here again?? I loaded 5.3.0.3. > My ods file was OK, looked good, I entered date, time, saved, 3 times, > worked good. > xls file opened OK, looked good, entered date, time, saved, it took a long > time saving, and went from 3.7 to 150.2mb. > Opened xls 2 more times, blank. I took screen shots. Hi Mark, We know that it didn't work in 5.3.0. The fix from today goes into 5.3.1 which will be released in about a month, and also in 5.2.6 which will be similarly be released in about a month. Until then, you will need to use 5.2.4. Sorry for the trouble. *** Bug 106104 has been marked as a duplicate of this bug. *** *** Bug 106589 has been marked as a duplicate of this bug. *** Confirm the problem is fixed in 3.5.1. |