Bug 106261

Summary:	exporting tables in footers to .doc can result in exporter thinking its a subtable
Product:	LibreOffice	Reporter:	Caolán McNamara <caolan.mcnamara>
Component:	Writer	Assignee:	Caolán McNamara <caolan.mcnamara>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	medium
Version:	5.2.5.1 release
Hardware:	All
OS:	All
Whiteboard:	target:5.4.0 target:5.2.7 target:5.3.2
Crash report or crash signature:		Regression By:
Attachments:	example to export to .doc

Description Caolán McNamara 2017-03-01 17:16:42 UTC

Description:
As in the attached demo, on export to .doc the export filter will have to process the same table twice to export it in two footers. On the second export it finds the tables nodes in its map already and increments their depth, leading to the 0x7 cell/row marks replaced with the para breaks used for subtables

Steps to Reproduce:
1. export to .doc

Actual Results:  
reload and the last footer isn't the same as the previous footer

Expected Results:
both th same


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0

Comment 1 Caolán McNamara 2017-03-01 17:17:11 UTC

Created attachment 131565 [details]
example to export to .doc

Comment 2 Commit Notification 2017-03-01 20:50:35 UTC

Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=6f3e24ad64dd40b3ef8def7d879ba395a16874a1

Resolves: tdf#106261 throw away old node map for table

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 3 Commit Notification 2017-03-03 21:06:24 UTC

Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-5-2":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=c496b67a52ee4b5c7f9053cfe3dc54290e8d6392&h=libreoffice-5-2

Resolves: tdf#106261 throw away old node map for table

It will be available in 5.2.7.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 4 Commit Notification 2017-03-03 21:07:57 UTC

Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-5-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=d4b88da06634d85709b45176811ac3a0791f4c99&h=libreoffice-5-3

Resolves: tdf#106261 throw away old node map for table

It will be available in 5.3.2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.