| Summary: | Admin Console: missing version numbers | ||
|---|---|---|---|
| Product: | LibreOffice Online | Reporter: | Pranav Kant <pranavk> |
| Component: | LibreOffice | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | aron.budea, pranavk |
| Priority: | medium | Keywords: | difficultyBeginner, easyHack, skillCpp, skillJavaScript |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 123137 | ||
| Attachments: | screenshot of admin page | ||
|
Description
Pranav Kant
2017-03-09 10:00:29 UTC
We already show the version information in the Help->About dialog when opening a document. The server sends LOOLWSD version info in 'loolserver' message and LOKit version information in 'lokitversion' message (see wsd/protocol.txt for details). See how this version information is sent to loleaflet by the server in wsd/ClientSession.cpp (grep for 'version') and replicate the same logic in Admin console backend (in wsd/Admin.cpp). This requires adding a new admin protocol message in wsd/Admin.cpp (see AdminRequestHandler::adminCommandHandler for handling of other admin protocol messages eg: 'total_mem', 'settings' etc. Created attachment 131868 [details]
screenshot of admin page
Hi, I have been working on this issue and i have attached the screenshot of the resulting admin page. Please let me know if this is the expected result. And about the styling, should i put this information in a footer? Looks wonderful, awesome. I think better if we have a new section on the left sidebar 'About' and then you can put this kind of information there. These are not really settings, so doesn't belong here. Can you put your patch on gerrit. See [1]. Things would be changed a little for online repository. You can either install git-review from your distro (apt-get install git-review ?) and then do 'git review' command would push your patch to gerrit, or if that doesn't work for some reason, you can just push to : git push logerrit HEAD:refs/for/<banchname> [1] https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch I have uploaded the patch here. https://gerrit.libreoffice.org/#/c/35199/ A few errors seem to have come in though. 1. admmin-bundle.js was being ignored by git so i 'git add -f' it. Now it looks like a new admin-bunde.js has been added instead of being modified. 2. By mistake i forgot to remove the previous html i wrote. That was very careless of me. 1. The reason why it isn't in the repository is that the files are generated, I'd look in loleaflet/src/admin, and add the corresponding code there (disclaimer: I don't know the code). 2. That's all right, it can still be fixed, you can update your current patch by making changes (in this case, "git rm <unwanted file>"), using "git commit --amend", and submitting to gerrit again (see relevant part of [1]). [1] https://wiki.documentfoundation.org/Development/GetInvolved 1. As you said, i had a look in src/admin and i realised that admin-bundle.js was autogenerated and it takes its code from the various js files in admin folder. So, i will change the AdminSocketSetting.js instead of admin-bundle.js. 2. I read more about git review and by using 'git commit --amend resolved the error'. I have updated the new patch now. Thanks Aron |