Bug 106917

Summary:	Tooltip for directly export as PDF button is incorrect
Product:	LibreOffice	Reporter:	Jean-Baptiste Faure <jbfaure>
Component:	UI	Assignee:	Roman Kuznetsov <79045_79045>
Status:	VERIFIED FIXED
Severity:	trivial	CC:	buzea.bogdan, philipz85, vsfoote, xiscofauli
Priority:	low
Version:	5.3.0.3 release
Hardware:	All
OS:	All
Whiteboard:	target:6.3.0
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	108400

Description Jean-Baptiste Faure 2017-04-02 12:40:03 UTC

The tooltip for the PDF export is "Export as PDF" when it should be "Export directly as PDF".
Indeed you can have 2 PDF export buttons, the default one which export as PDF using the current export settings and a second which open the option dialog for PDF export as the menu File > Export as PDF. If you add this second button in the standard toolbar, you will have 2 buttons with the same tooltip (and the same icon).

In the customize dialog allowing to add this second PDF export button, this command does not have any description. This description could be something like "Open the option dialog for PDF export then export to PDF".

Reproducible in LO 5.3 and master.

Best regards. JBF

Comment 1 Ysabeau 2017-04-03 07:31:19 UTC

I too saw that!
I hope it be fixed soon.

(and I wonder why it is  the button direct pdf that is on the standard toolbar instead of the button that asks the parameters).

Comment 2 V Stuart Foote 2017-04-03 18:32:43 UTC

There are two UNO commands .uno:ExportToPDF and .uno:ExportDirectToPDF both have correct context menu labels, but are duplicating their tooltip labels. 

The Export Direct to PDF uses user default settings for the PDF export, while the Export to PDF opens the dialog.  The Export Direct is the default button on the Standard toolbar, but the Export to PDF can be added via customize--but that would be an uncommon customization to have both present.

@Jay, when you added the tooltip to GenericCommands.xcu [1][2] was the duplicate intentional, or just an oops?

=-ref-=

https://cgit.freedesktop.org/libreoffice/core/commit/?id=37ad8daabf596e039b4ca62e06e91d5a83128b7c
https://gerrit.libreoffice.org/#/c/28742/

Comment 3 Yousuf Philips (jay) (retired) 2017-04-06 21:19:14 UTC

(In reply to V Stuart Foote from comment #2)
> @Jay, when you added the tooltip to GenericCommands.xcu [1][2] was the
> duplicate intentional, or just an oops?

Yes it was intentional as .uno:ExportToPDF isnt available in the toolbar, unlike Print and Print Directly are.

Comment 4 Roman Kuznetsov 2018-12-25 14:28:32 UTC

https://gerrit.libreoffice.org/#/c/65605/

Comment 5 Commit Notification 2018-12-28 06:42:58 UTC

Roman Kuznetsov committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/8394ca86e834d2a97c898c3d7552f31522ef936f%5E%21

tdf#106917 Changed tooltip for .uno:ExportDirectToPDF

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 6 BogdanB 2019-01-13 13:18:10 UTC

Solved.

Verified in
Version: 6.3.0.0.alpha0+
Build ID: be8897d9c63a77b223a9c0aed1d2eb689e0e0082
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-01-02_04:49:04
Locale: ro-RO (ro_RO.UTF-8); UI-Language: en-US
Calc: threaded