Bug 107964

Summary: 'Choose Themes' command no longer works
Product: LibreOffice Reporter: Yousuf Philips (jay) (retired) <philipz85>
Component: CalcAssignee: Not Assigned <libreoffice-bugs>
Status: VERIFIED FIXED    
Severity: normal CC: aron.budea, caolan.mcnamara, jalojo, serval2412
Priority: medium Keywords: bibisected, bisected, regression
Version: 5.4.0.0.alpha0+   
Hardware: All   
OS: All   
Whiteboard: target:5.5.0 target:5.4.0.1
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 107332    

Description Yousuf Philips (jay) (retired) 2017-05-19 20:49:51 UTC 
Steps:
1) Open Calc
2) View > Toolbars > Tools
3) Click 'Choose Themes' button
4) Nothing happens

Regression as this works in 5.3

Version: 5.4.0.0.alpha1+
Build ID: 296c2296f5565556eea9fab51563050f28bbcafc
CPU threads: 2; OS: Linux 4.4; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2017-05-17_00:33:24
Locale: en-US (en_US.UTF-8); Calc: group
Comment 1 Jacques Guilleron 2017-05-19 21:45:25 UTC 
Hi Yousuf,

I reproduce from
LO  5.4.0.0.alpha1+ Build ID: 0025fc13d805751f8eeb14febbdd0033e0a6d91e
CPU threads: 2; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@39, Branch:master, Time: 2017-05-04_05:21:32
Locale: fr-FR (fr_FR); Calc: CL
and upper versies
but not with
LO 5.4.0.0.alpha0+ Build ID: 3a36cf434fb4a967c9ea767cb7ac5f4da0502a0d
CPU threads: 2; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@39, Branch:master, Time: 2017-04-28_06:33:58
Locale: fr-FR (fr_FR); Calc: CL
Comment 2 Julien Nabet 2017-05-20 12:41:17 UTC 
Regression from https://cgit.freedesktop.org/libreoffice/core/commit/?id=062e7063a94673d016a91a16a30e86b82c70a03d

Caolán: ShowStyles function from wizards/source/template/Samples.xba is missing here.
Comment 3 Caolán McNamara 2017-05-21 18:04:49 UTC 
great, yet another hidden way to call these horrors
Comment 4 Commit Notification 2017-05-21 18:08:17 UTC 
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ee79b9875ce4914c950c349c61f39e6dfdd0cc6b

Resolves: tdf#107964 partially revert "unused basic dialog"

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2017-05-21 18:09:06 UTC 
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-5-4":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=9cce34decd04807de886cd2d25427bd59291bfc0&h=libreoffice-5-4

Resolves: tdf#107964 partially revert "unused basic dialog"

It will be available in 5.4.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Julien Nabet 2017-05-22 20:44:08 UTC 
On pc Debian x86-64 with master sources updated today, I don't reproduce the bug.

Thank you Caolán!