| Summary: | Sheet comments toggle state should be evaluated when switching sheets | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Yousuf Philips (jay) (retired) <philipz85> |
| Component: | Calc | Assignee: | Gülşah Köse <gulsah.1004> |
| Status: | CLOSED FIXED | ||
| Severity: | normal | CC: | gulsah.1004, timur |
| Priority: | medium | Keywords: | implementationError |
| Version: | 6.0.0.0.alpha0+ | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:5.5.0 target:5.4.0.1 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 107258 | ||
| Attachments: | screencast | ||
|
Description
Yousuf Philips (jay) (retired)
2017-05-26 00:10:33 UTC
Not reproducable for me. 10th step hides comment as it's supposed to be LibreOfficeDev 5.5.0.0.alpha0 As discussed in https://bugs.documentfoundation.org/show_bug.cgi?id=84837#c22: "The code acts on the selected sheet(s)..." 3. Show comment in Sheet1;B2 - View > Comments is toggled, why, does it understand it' the only comment, what about toolbar button? 4. Add a new Sheet2 - View > Comments and button are unavailable, right, because it's for sheet; 6. Show comment in Sheet2;B2 - View > Comments is toggled and button is not, why? If we add comment to some other cell, it's OK, problem is only in adding comment for the same cell as in Sheet1; 9. Switch to sheet2 - command and button are not toggled, but they should be; 10. View > Comments wont hide the comments - right So, I can reproduce. But I won't confirm solely because Gülşah wrote she can't so I kindly ask here to check why. Created attachment 133631 [details]
screencast
@Gulsah: Would suggest you download a TDF daily build if you cant repo this on your git build.
Of course, I'll try. @Yousuf are you sure the steps exactly true? Could it be a step you missed? I saw the screencast now. Sorry. I'll try to reproduce that bug and confirm that tonight. And i'll fix it. When add new sheet by click blank bar steps are wrong but add new sheet via "+" yes steps are true. So Confirmed and will be fixed ASAP Fixed with https://gerrit.libreoffice.org/#/c/38310/ Gulsah Kose committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=57bdb06703ecf233d12304d4e71e1f40d29da327 tdf#108098 Correct detection of MIXED state. It will be available in 5.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Gulsah Kose committed a patch related to this issue. It has been pushed to "libreoffice-5-4": http://cgit.freedesktop.org/libreoffice/core/commit/?id=81e7ef8d3941de527f21c1508389c9e09518680b&h=libreoffice-5-4 tdf#108098 Correct detection of MIXED state. It will be available in 5.4.0.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Tested and looks fixed to me. Adding a new sheet by clicking the blank bar is incorrect, however adding a new sheet by pressing the "+" button is correct. The issue will be rectified as soon as possible, therefore it's been confirmed. https://wordwipe.io |