| Summary: | CRASH: Bad allocation if undo count is set to zero (0) (steps in comment 3) | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Telesto <telesto> |
| Component: | Draw | Assignee: | Michael Stahl (allotropia) <michael.stahl> |
| Status: | CLOSED FIXED | ||
| Severity: | critical | CC: | ilmari.lauhakangas, michael.stahl, xiscofauli |
| Priority: | high | Keywords: | haveBacktrace |
| Version: | 5.4.0.1 rc | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=108889 | ||
| Whiteboard: | target:6.0.0 target:5.4.0.2 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 109386 | ||
| Attachments: | GDB trace of crash with master | ||
|
Description
Telesto
2017-06-29 14:28:53 UTC
@Michael, one for you? I don't get a crash. For testers: https://help.libreoffice.org/Common/Memory#Number_of_undo_steps Version: 6.0.0.0.alpha0+ (x64) Build ID: e0f67add2ec56706ce06a03572535266f21c0303 CPU threads: 4; OS: Windows 6.19; UI render: default; TinderBox: Win-x86_64@42, Branch:master, Time: 2017-06-27_23:04:56 Locale: fi-FI (fi_FI); Calc: group Arch Linux 64-bit, KDE Plasma 5 Version: 6.0.0.0.alpha0+ Build ID: 98befbb26217b0bf3f35354e418a355280c52cfc CPU threads: 8; OS: Linux 4.11; UI render: default; VCL: kde4; Locale: fi-FI (fi_FI.UTF-8); Calc: group Built on June 29th 2017 (In reply to Buovjaga from comment #2) > I don't get a crash. > Hmm, I think I know why. I tried it with a simple shape after the first crash, without resetting the user profile. Sorry for the fuzz 1. Save https://upload.wikimedia.org/wikipedia/commons/3/3d/LARGE_elevation.jpg 2. Open Draw 3. Set the undo count to zero (https://help.libreoffice.org/Common/Memory#Number_of_undo_steps) 4. Insert - Image -> LARGE_elevation.jpg 5. Delete it -> crash Maybe zero should be forbidden after all. I'm generating quite a lot of crashes: bug 108833, bug 108863, bug 108836. :( Created attachment 134412 [details] GDB trace of crash with master Arch Linux 64-bit, KDE Plasma 5 Version: 6.0.0.0.alpha0+ Build ID: 98befbb26217b0bf3f35354e418a355280c52cfc CPU threads: 8; OS: Linux 4.11; UI render: default; VCL: kde4; Locale: fi-FI (fi_FI.UTF-8); Calc: group Built on June 29th 2017 *** Bug 108833 has been marked as a duplicate of this bug. *** Ok I didn't notice 108836 was fixed. *** This bug has been marked as a duplicate of bug 108836 *** (In reply to Buovjaga from comment #7) > Ok I didn't notice 108836 was fixed. > > *** This bug has been marked as a duplicate of bug 108836 *** Nope, these bugs (bug 108833, bug 108863) aren't fixed with bug 108836. I didn't notice more issues when I reported bug 108836. Now I found multiple problems :( The main question is what to do. 1. Let it go for know (nobody uses it anyhow) 2. The use of 0 should be forbidden 3. Fix all individual crashing bugs related to 0 Version: 6.0.0.0.alpha0+ Build ID: 83634c9d11ea730f6525c66ba26a87e9d1ef3936 CPU threads: 4; OS: Windows 6.19; UI render: default; TinderBox: Win-x86@42, Branch:master, Time: 2017-06-30_08:34:23 Locale: nl-NL (nl_NL); Calc: CL Michael Stahl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=495284716f49072e432b8425944cc67dfe0df0e0 tdf#108863 sd: disable Undo earlier if no Undo Steps It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Michael Stahl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a54ba50db2c341f0f0e47d77dbe64a6e588bc911 tdf#108863 svx: fix use-after-free in SdrEditView::DeleteMarkedObj() It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. fixed on master (In reply to Michael Stahl from comment #11) > fixed on master Thanks for fixing =) Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-5-4": http://cgit.freedesktop.org/libreoffice/core/commit/?id=0755d19069403ef16f55326c3a567ddf84d4d9ec&h=libreoffice-5-4 tdf#108863 sd: disable Undo earlier if no Undo Steps It will be available in 5.4.0.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-5-4": http://cgit.freedesktop.org/libreoffice/core/commit/?id=c6640f93273475b6d686f14820051cbfa4b1b6c2&h=libreoffice-5-4 tdf#108863 svx: fix use-after-free in SdrEditView::DeleteMarkedObj() It will be available in 5.4.0.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. *** Bug 109054 has been marked as a duplicate of this bug. *** This will give you an opportunity to show your stylist what worked for you in the past, and what didn't. https://dltutuapp.com/tutuapp-download/ https://showbox.run/ https://kodi.software/ |
