| Summary: | No hover effect in table design sidebar tab | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Tamás Zolnai <zolnaitamas2000> |
| Component: | Impress | Assignee: | Kshitij <kshitijpathania> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | mentoring |
| Priority: | medium | Keywords: | difficultyBeginner, easyHack, skillCpp |
| Version: | 6.0.0.0.alpha0+ | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=127369 | ||
| Whiteboard: | target:6.1.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 112630 | ||
| Attachments: | How hover looks like for layout sidebar tab | ||
|
Description
Tamás Zolnai
2017-08-14 12:24:30 UTC
Created attachment 135544 [details]
How hover looks like for layout sidebar tab
Repro with: Version: 6.0.0.0.alpha0+ Build ID: f1a896c71c495bdef5861eb664581507b6b9b5bb CPU threads: 4; OS: Windows 6.19; UI render: default; TinderBox: Win-x86@42, Branch:master, Time: 2017-08-13_07:38:19 Locale: nl-NL (nl_NL); Calc: CL Let's turn it into a easy hack. The code is here: sd/source/ui/table/TableDesignPane.hxx sd/source/ui/table/TableDesignPane.cxx Hi! I am starting to work on this bug. Hi ,Iam new to libreoffice .I have gone through TableDesignPane.cxx & TableDesignPane.hxx but was unable to find something .Also I wanted to know which file to look in which hover effect in slide layout sidebar tab is implemented and how to use this information.PLease help me. (In reply to Kshitij from comment #5) > Hi ,Iam new to libreoffice .I have gone through TableDesignPane.cxx & > TableDesignPane.hxx but was unable to find something .Also I wanted to know > which file to look in which hover effect in slide layout sidebar tab is > implemented and how to use this information.PLease help me. Hi, Some more info about the bug. As I see table style list is stored in TableDesignWidget::m_pValueSet member, which has TableValueSet type. So the change might be related to this class or this member. A better example for checking how to use hover effect is the template manager dialog (in Impress: File -> Templates -> Manage Templates). The table manager code is here: sfx2/source/doc/templatedlg.cxx, but the hover effect handling can be found in its base class (ThumbnailView::MouseMove).
> manager dialog (in Impress: File -> Templates -> Manage Templates). The
> table manager code is here: sfx2/source/doc/templatedlg.cxx, but the hover
> effect handling can be found in its base class (ThumbnailView::MouseMove).
Sorry, ThumbnailView is not the base class of template dialog, but the base class of its mpLocalView member. The mpLocalView handles the icons on the dialog.
(In reply to Kshitij from comment #4) > Hi! I am starting to work on this bug. When you work on a bug assign it to yourself (see Assignee field) and also change the status to assigend. A polite ping, still working on this bug? Yes,working on it .Will commit something soon. A polite ping, still working on this bug? (In reply to Xisco Faulí from comment #11) > A polite ping, still working on this bug? Yeah,please refer to https://gerrit.libreoffice.org/#/c/42882/ .If you wish ,you can work in parallel with me. A polite ping, still working on this bug? Kshitij Pathania committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=584a73ce23706c1e0dfbf32b4dbdbe6c79fb0ef2 tdf#111801 added hover state to tabledesign sidebar It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |