| Summary: | A highlighting change within the textbox is applied but doesn't show up on screen | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Telesto <telesto> |
| Component: | LibreOffice | Assignee: | Armin Le Grand <Armin.Le.Grand> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | Armin.Le.Grand, ilmari.lauhakangas, lo_bugs, raal, xiscofauli |
| Priority: | medium | Keywords: | bibisected, bisected, regression |
| Version: | 6.0.0.0.alpha0+ | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:6.0.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: |
printscreen
output from bibisect in daily Linux dbgutil repository |
||
|
Description
Telesto
2017-08-16 09:41:54 UTC
Repro. Regression: it works in 5.4 Arch Linux 64-bit, KDE Plasma 5 Version: 6.0.0.0.alpha0+ Build ID: 4082b5874adddedf8332fe977b6bb47b6949b302 CPU threads: 8; OS: Linux 4.12; UI render: default; VCL: kde4; Locale: fi-FI (fi_FI.UTF-8); Calc: group Built on August 31st 2017 Arch Linux 64-bit, KDE Plasma 5 Version: 5.4.0.3 Build ID: 5.4.0-1 CPU threads: 8; OS: Linux 4.12; UI render: default; VCL: kde4; Locale: fi-FI (fi_FI.UTF-8); Calc: group Created attachment 135984 [details] printscreen no repro. Version: 6.0.0.0.alpha0+ Build ID: 4b4ebb15456af443347679a7e7e8726c090a5bf5 CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk2; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2017-08-30_23:53:37 Using button from sidebar - see printscreen (In reply to raal from comment #2) > Created attachment 135984 [details] > printscreen > > no repro. Version: 6.0.0.0.alpha0+ understand now, reproduced Created attachment 136019 [details]
output from bibisect in daily Linux dbgutil repository
Working on debian-stretch with xfce desktop in the daily Linux dbgutil
bibisect repository, I see that the bug entered LibreOffice somewhere
in the 39 commits:
commit date s-h
-------- ---------- --------
good 1ab3f526 2017-08-10 368b583b
bad 2b43da38 2017-08-11 4e2b4486
Several commits mention editviewoverlay, including 71a8c7a5:
editviewoverlay: correct reaction on property change
I am removing keyword bibisectRequest and adding keyword bibisected.
Regression introduced by: author Armin Le Grand <Armin.Le.Grand@cib.de> 2017-08-04 16:56:43 (GMT) committer Armin Le Grand <Armin.Le.Grand@cib.de> 2017-08-10 13:17:58 (GMT) commit f06b48a5dddab20fd1bbf9b5f3e8543593f5e590 (patch) tree ce3bb9e57cdb21a8414a49bf919b1c442d2687ea parent 2ae717f2d722d78b29b51dc40194b64ab3bb5bc8 (diff) editviewoverlay: Allow EditView to run in Overlay Bisected with: bibisect-linux64-6.0 Adding Cc: to Armin Le Grand Problem is commit 6c1fc9e94e36b4f74136bc044cc9a4b72f79d53f from 2014 where maTextFillColor was added to TextSimplePortionPrimitive2D, bu tis not tested in operator==, so a change in attributation o fthe text in that respect is not detected. FGix on gerrit, TextSimplePortionPrimitive2D which is very central to rendering was changed for one single case (Outliner::DrawingTab), I am not sure if that change was good, I will try to find out why this was done Armin Le Grand committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=41c704a8d6ca225e0ba0b1deb730c2bead66da25 tdf#111853 Added TextFillColor to operator== It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. The problem appears to be gone in daily Linux dbgutil bibisect repository version 2017-09-13. |