| Summary: | FORMATTING (Styles): The vertical frame alignment setting is not preserved when the document is opened | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Bastián Díaz <diazbastian> |
| Component: | Writer | Assignee: | Justin L <jluth> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caolan.mcnamara, eagleview7, jluth |
| Priority: | medium | Keywords: | bibisected, regression |
| Version: | 5.1.0.3 release | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:6.0.0 target:5.4.2 target:5.3.7 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: | screenshot | ||
|
Description
Bastián Díaz
2017-08-18 06:45:27 UTC
Created attachment 135638 [details]
screenshot
A test file in this case is not useful, but I share a screenshot exemplifying the problem described above.
Confirmed with Version: 5.4.0.3 (x64) Build ID: 7556cbc6811c9d992f4064ab9287069087d7f62c CPU threads: 4; OS: Windows 6.19; UI render: default; Locale: ru-RU (ru_RU); Calc: group and with Version: Version: 5.1.0.3 (x64) Build ID: 5e3e00a007d9b3b6efb6797a8b8e57b51ab1f737 CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; Locale: ru-RU (ru_RU) but NOT with Version: 5.0.0.5 (x64) Build ID: 1b1a90865e348b492231e1c451437d7a15bb262b Locale: ru-RU (ru_RU) File format is ODT. The problem is on load. Saving the attribute happens successfully, which is visible when opening the file with 5.0 saved with a later version. Bibisecting with bibisect-win32-5.1 shows that a file with non-top vertical alignment set for a frame style crashes starting with this commit: https://cgit.freedesktop.org/libreoffice/core/commit/?id=664197d95b > author Justin Luth <justin_luth@sil.org> 2015-09-10 08:41:11 (GMT) > committer Justin Luth <justin_luth@sil.org> 2015-10-19 04:35:55 (GMT) > commit 664197d95becd516c3dac25a50439078ba61e051 > tree 85199c219b30c973a1c151b360c490fcfd16bce3 > parent 51df957e1a40d2f3511345c1600c05dd35f34b6b > tdf#36117 .docx preserve page vertical alignment after RT and after that, such files start opening with wrong (top) vertical alignment in these styles with this commit: https://cgit.freedesktop.org/libreoffice/core/commit/?id=36a3885eb2 > author Caolán McNamara <caolanm@redhat.com> 2015-11-01 21:11:29 (GMT) > committer Caolán McNamara <caolanm@redhat.com> 2015-11-01 21:13:13 (GMT) > commit 36a3885eb2ec26acbce587497db68606feddfc42 > tree ea475fe4c6fca75d157886f7def7d7b73270e8fd > parent c2a76550a287adf8bdbe93c02395fb80cb11c950 > crashtesting: failure on tdf89191-1.odt > crash since > > commit 664197d95becd516c3dac25a50439078ba61e051 Testing between these commits (712 intermediate commits) is impossible, but it seems highly probable that one of these two commits is the real cause. Yup - my problem from bug 36117 commit 664197d95becd516c3dac25a50439078ba61e051 proposed fix: https://gerrit.libreoffice.org/41538 Justin Luth committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=10dc371d31f003ac3ed9b89ca1db95d36603603f tdf#111891 unostyle: use default handler for non-page style It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. requested backport to 5.3 Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-5-4": http://cgit.freedesktop.org/libreoffice/core/commit/?id=461aa995d75f031209711feda9d785d915c42dd2&h=libreoffice-5-4 tdf#111891 unostyle: use default handler for non-page style It will be available in 5.4.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-5-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=db7a015c86248bd2a3d090240f9360f84b3bec8c&h=libreoffice-5-3 tdf#111891 unostyle: use default handler for non-page style It will be available in 5.3.7. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Duplicate of bug 101236. *** Bug 101236 has been marked as a duplicate of this bug. *** |