| Summary: | assertion at dbggui.cxx:47, solar mutex locked | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Terrence Enger <lo_bugs> |
| Component: | Base | Assignee: | Michael Stahl (allotropia) <michael.stahl> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | michael.stahl |
| Priority: | medium | Keywords: | haveBacktrace |
| Version: | 6.0.0.0.alpha0+ | ||
| Hardware: | x86-64 (AMD64) | ||
| OS: | Linux (All) | ||
| Whiteboard: | target:6.0.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 105537 | ||
| Attachments: |
output from bibisect in daily Linux dbgutil repository
typescript of make debugrun |
||
|
Description
Terrence Enger
2017-08-22 13:47:43 UTC
Created attachment 135733 [details]
typescript of make debugrun
line what
---- --------------------------
36 run
246 assertion
252 info threads
273 thread apply all backtrace
512 backtrace full
This is from a local-build LibreOffice, commit 461ba1db, 2017-08-04
22:57 UTC, configured:
CC=ccache /usr/bin/gcc
CXX=ccache /usr/bin/g++
--enable-option-checking=fatal
--enable-dbgutil
--enable-debug
--without-system-postgresql
--without-myspell-dicts
--with-extra-buildid
--without-doxygen
--with-external-tar=/home/terry/lo_hacking/git/src
--without-package-format
built and running on debian-stretch.
I observed, perhaps coincidentally, that the "good" versions I tested while bibisecting each did not show values in the drop-down boxes or in the opened drop-down lists. The "bad" versions did show values. Whoops. The tale is more complicated: I managed to raise the same
assertion in drop-down list Regal in earlier version dbgutil
2017-05-19.
In the -till53 dbgutil repository, I narrowed the appearance of the
assertion on drop-down list Regal to the 64 source commits
42062d99..0d2797fd. In that range, I see
commit c00d8271ba443c4f0acf657c226eea4824597f95
Author: Michael Meeks <michael.meeks@collabora.com>
Date: Tue Oct 18 21:38:34 2016 +0100
vcl: assert solar mutex is held for various timer / scheduler ops.
Bringing paranoia to some source-code near you.
...
although, funnily enough, dbggui.cxx:47 is git blame'd to 2014.
I conclude that the problem is somewhere else, and that my good/bad
determinations while trying to bibisect are mere noise. I am removing
keywords bibisected, regression.
i think this assertion doesn't happen any more on master as the Scheduler no longer uses SolarMutex. but the locking in that FmXFormShell class is still a disaster so i've hit it with the big hammer. Michael Stahl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a871dbed8abfeaeb4faf44129b8983c26f7a9cb3 tdf#111970 svx: use SolarMutex for locking in FmXFormShell It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Indeed the problem is gone on debian-stretch in some recent versions from the daily Linux dbgutil bibisect repository. I am setting status VERIFIED FIXED. |