| Summary: | Pages named as 'Slide X' rather than 'Page X' | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Yousuf Philips (jay) (retired) <philipz85> |
| Component: | Draw | Assignee: | Muhammet Kara <kara> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | fitojb, jalojo, kara |
| Priority: | medium | ||
| Version: | Inherited From OOo | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=114175 https://bugs.documentfoundation.org/show_bug.cgi?id=160162 |
||
| Whiteboard: | target:6.4.0 target:7.4.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 107280 | ||
|
Description
Yousuf Philips (jay) (retired)
2017-08-31 07:10:53 UTC
Hi Yousuf, Reproduced with LO 6.0.0.0.alpha0+ Build ID: 9420391cc9f6af2a16c1db72596f277439df29e9 CPU threads: 2; OS: Windows 6.1; UI render: default; TinderBox: Win-x86@39, Branch:master, Time: 2017-08-29_06:08:06 Locale: fr-FR (fr_FR); Calc: CL also with LO 3.5.3.2 Version ID : 235ab8a-3802056-4a8fed3-2d66ea8-e241b80 and OOo 3.1.0 000310m11 (Build:9399) on windows XP so Inherited from OOo. Bug not reproducible in version Version: 6.3.0.0.alpha0+ (x64) Build ID: 0f25a3c36f27fd51453b9a9115f236b83c143684 CPU threads: 8; OS: Windows 10.0; UI render: GL; VCL: win; TinderBox: Win-x86_64@42, Branch:master, Time: 2018-11-27_20:06:55 Locale: zh-TW (zh_TW); UI-Language: en-US Calc: threaded Correct comment 2: Still exists in Version: 6.3.0.0.alpha0+ Build ID: e4c2d0bb57ab8ea8f5c400d103d01376b8140f22 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: kde5; TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2018-11-30_21:37:10 Locale: en-US (en_US); UI-Language: en-US Calc: threaded Muhammet Kara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/942d1d2ea59bf4605f2c464a6b29c967fa9f8de8 tdf#112126: Correct naming for pages in Draw It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. I want to write the unit test for this fix. However, I noticed that the display name of the page is stored under Document->DrawPages->@page_number->LinkDisplayName. But it is only a read-only property, do I need to write a method to get this property and then complete the unit test or is there some other workaround? Nevermind, I just realized that SdPage::GetName() is already there, just need to figure out how to use it. VaibhavMalik4187 committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/5c9e6a6a2b7fbdfc3ee32ef2b9d5433270fd6161 tdf#112126 Added Unit Test It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |