Bug 112601

Summary: Build issue on Windows when linking mergedlo.dll
Product: LibreOffice Reporter: Tomofumi Yagi <yagit>
Component: LibreOfficeAssignee: Not Assigned <libreoffice-bugs>
Status: RESOLVED NOTABUG    
Severity: normal CC: xiscofauli
Priority: medium    
Version: 6.0.0.0.alpha0+   
Hardware: x86-64 (AMD64)   
OS: Windows (All)   
Whiteboard:
Crash report or crash signature: Regression By:
Attachments: a workaround patch

Description Tomofumi Yagi 2017-09-24 02:36:02 UTC 
Description:
A few days ago, I got a build error when I built LibreOffice master branch on Windows.
The error messages are follows. 
- - - - - - - - - - - - - - - - - - - -
[build LOC] libreoffice
[build LOC] top level modules: libreoffice
[build DEP] LNK:Library/mergedlo.dll
[build LNK] Library/mergedlo.dll
[build CUS] postprocess/images
/usr/bin/sh: -c: line 1: syntax error: unexpected end of file
make[1]: *** [C:/cygwin/home/yagit/lode/dev/core/Library_merged.mk:11: C:/cygwin/home/yagit/lode/dev/core/instdir/program/mergedlo.dll] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:266: build] Error 2
- - - - - - - - - - - - - - - - - - - -


Steps to Reproduce:
I'm using Visual Studio 2017 Pro(version 15.3.4) on Windows10 Pro 64 bit(version1703).
This error occurs not only LibreOffice x86_64 build but also LibreOffice x86 build. 
I can't reproduce this error with Visual Studio 2015.

Actual Results:  
Build is not successful.

Expected Results:
Build is successful.


Reproducible: Always

User Profile Reset: No

Additional Info:
I've noticed that I can avoid this error by reverting commit 84b0f0631574(consistent naming of externals: xml2 -> libxml2).
https://gerrit.libreoffice.org/gitweb?p=core.git;a=commit;h=84b0f0631574832c5939cc63456fd1322e67339f

Then I wrote a workaround patch.

Perhaps the command line for linking mergedlo.dll is too long,or ARG_MAX of cygwin is too small.
Although I can't find the root cause.


User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.113 Safari/537.36
Comment 1 Tomofumi Yagi 2017-09-24 02:40:00 UTC 
Created attachment 136500 [details]
a workaround patch

This patch avoids that build error.
Comment 2 Tomofumi Yagi 2017-09-24 02:54:05 UTC 
My autogen.input is follows.

$ cat autogen.input
--with-distro=LibreOfficeWin64
--enable-symbols
--disable-werror
--with-visual-studio=2017
--with-lang=ja
--without-help
Comment 3 Xisco Faulí 2017-09-28 10:58:06 UTC 
Hello Tomofumi,
Thanks for reporting this issue.
Since this is not an issue in LibreOffice's software, I recommend you to send an email to the dev mailing list [1] instead, the right place for this kind of  problems.
Regarding the patch, could you please submit it to gerrit as described here:
https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch
Closing as RESOLVED NOTABUG

[1] https://lists.freedesktop.org/mailman/listinfo/libreoffice
Comment 4 Tomofumi Yagi 2017-10-07 04:17:59 UTC 
(In reply to Xisco Faulí from comment #3)

Hi Xisco Faulí,
Christian Lohmaier committed a patch related to this issue.

https://github.com/LibreOffice/core/commit/499194508c8cf91fbbc21f882bcf4ace77e19eaa#diff-fadefc091c75e3bcea28c2fc8a883b6d

I confirmed that this commit resolved build breakage.
Thanks for fixing!