| Summary: | Options for Number recognition in Writer tables deserve better default: turned on (only functioning when 'Number Recognition' is on!) | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Cor Nouws <cno> |
| Component: | Writer | Assignee: | Cor Nouws <cno> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | cno, heiko.tietze, thomas.lendo, xiscofauli |
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=72038 | ||
| Whiteboard: | target:6.2.0 target:6.3.0 target:6.2.5 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 113627, 113944 | ||
|
Description
Cor Nouws
2017-10-18 20:19:32 UTC
I'm against exposing (and actually duplicating here) every option in the menu. So before bringing the Format and Alignment into the menu I would remove Number Recognition. Jay, the menu is your topic? (In reply to Heiko Tietze from comment #1) > ... > menu. So before bringing the Format and Alignment into the menu I would > remove Number Recognition. eh... My proposal is not to add something to the menu :) (In reply to Cor Nouws from comment #2) > eh... My proposal is not to add something to the menu :) You mean to check the two boxes in Tools > Options but ignore it when the parent is unchecked (aka when disabled)? Makes sense. (In reply to Heiko Tietze from comment #3) > You mean to check the two boxes in Tools > Options but ignore it when the > parent is unchecked (aka when disabled)? Makes sense. Indeed, that is how it works, but they should be 'on' by default, added commit gerrit 61065 reason for the patch: if one turns on 'Number Recognition', the parent check box, it is most likely that 'Number format recognition' and 'Alignment' are desired too. Only then currency, separators are handled etc. It is not only that I find it odd myself, having to check those on. Also from students I got the feedback that it is not logic. The patch does just that; it is not extending or limitation any function. Cor, does your patch * set a checkmark into the checkboxes of 'Number format recognition' and 'Alignment' even if 'Number Recognition' is deactivated by default (so that the user has to uncheck these 2 options manually after activating 'Number Recognition') or * activate 'Number format recognition' and 'Alignment' at the same time when the user activates 'Number Recognition' but by default none of the 3 options has a checkmark? Hi Thomas, (In reply to Thomas Lendo from comment #7) > Cor, does your patch > * set a checkmark into the checkboxes of 'Number format recognition' and > 'Alignment' even if 'Number Recognition' is deactivated by default (so that > the user has to uncheck these 2 options manually after activating 'Number > Recognition') or this one. The reason: in most cases (that I've seen and can think of) it makes sense that the two detailed options are checked. (In reply to Cor Nouws from comment #8) Hi Cor, perfect. That's my preferred variant too. (In reply to Thomas Lendo from comment #7) > Cor, does your patch > * set a checkmark into the checkboxes of 'Number format recognition' and > 'Alignment' even if 'Number Recognition' is deactivated by default... It is working like this (otherwise I wouldn't complain to much). Default with the patch is [ ] Number Recognition - [x] Number format recognition - - [x] Alignment - ("-" for disabled) Before/Today it was/is [ ] Number Recognition - [ ] Number format recognition - - [ ] Alignment - Let's go for now with the simple solution. Cor Nouws committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=2b0cb3cf4ac35dbe29b203d24adf5604a860cde5 tdf#113241 better default for number recognition options in Writer tables It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Cor Nouws committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/f5b9590fc06811a9dff550c6998d1d1088507e23%5E%21 Revert "tdf#113241 better default for number recognition options in Writer tables" It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Cor Nouws committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/0d657498080aad86f4b97309fff9bf589c57dc2e%5E%21 Revert "tdf#113241 better default for number recognition options in Writer tables" It will be available in 6.2.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |