| Summary: | Crash when using color picker after parent toolbar is closed | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Emil Tanev <emo_assenov> |
| Component: | Calc | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | caolan.mcnamara, serval2412, xiscofauli |
| Priority: | medium | Keywords: | bibisected |
| Version: | 4.4 all versions | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=113647 | ||
| Whiteboard: | target:6.0.0 target:5.4.4 | ||
| Crash report or crash signature: | ["PaletteManager::AddRecentColor(Color const &,rtl::OUString const &,bool)"] | Regression By: | |
| Attachments: | bt with debug symbols | ||
|
Description
Emil Tanev
2017-11-07 15:13:12 UTC
Updating the description so that it is clearer. Open Calc (or any other) Undock the 2nd toolbar (the one with font color pickers) Open a color picker - Custom color Close the undocked toolbar by clicking X Click OK in the color picker The Palette manager was changed in range https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=5f27596bed3bd155a321b66650d04226e6f2d1ee%5E1..93c4e3c9349a1ea07b822a2824559ad28f4a9a5e and at that point the crash is already reproduced Created attachment 137604 [details]
bt with debug symbols
On pc Debian x86-64 with master sources updated today, I could reproduce this.
Note: only with a rendering like "gen" allowing to undock panels.
Caolán: as explained by Mike Kaganski here at https://bugs.documentfoundation.org/show_bug.cgi?id=113647#c3, perhaps the main problem is the possibility to undock panels. Vcl renderings like gtk3 won't undergo this kind of crashes because you can't undock panels. Any thoughts? Caolán McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=ff89d2216a26a57e0682f6a80e5eade6dabd499a Resolves: tdf#113695 crash in color picker after parent is closed It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. the modal dialog should really have the toolbar set as its parent I guess, but seeing as this problem has shown up a few times I've reworked it to survive its parent going away Verified in Version: 6.0.0.0.alpha1+ Build ID: cf36b5d5f598d9b5528b273858584e2b419b23e9 CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: x11; Locale: th-TH (ca_ES.UTF-8); Calc: group Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-5-4": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e9def9676ba4cfa5a89f823811fff6a2f68e242a&h=libreoffice-5-4 Resolves: tdf#113695 crash in color picker after parent is closed It will be available in 5.4.4. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |