| Summary: | StarOffice fonts still in use in wizard templates | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Timur Davletshin <timur.davletshin> |
| Component: | LibreOffice | Assignee: | Laurent Balland <jumbo4444> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | heiko.tietze, jumbo4444, timur.davletshin, xiscofauli |
| Priority: | medium | Keywords: | patch |
| Version: | Inherited From OOo | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=114749 https://bugs.documentfoundation.org/show_bug.cgi?id=121164 https://bugs.documentfoundation.org/show_bug.cgi?id=121255 |
||
| Whiteboard: | target:6.3.0 target:6.2.0.2 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 113825 | ||
| Attachments: | Little script to fix fonts | ||
|
Description
Timur Davletshin
2017-11-08 15:46:14 UTC
Created attachment 137618 [details]
Little script to fix fonts
I made little research and successfully fixed vulnerable files with script attached. I'm not very familiar with internal structure of ODF but it worked for me.
Another two affected templates include: 1. share/xslt/DocBookTemplate.stw (also in very old OO.o 1.x-2.x file format). 2. share/template/common/internal/html.stw Hi Timur, Thanks for reporting this issue and providing a script to fix it automatically. Let's add the UX Team to see what they think about it. Regards Albany -> Liberation Sans Cumberland -> Liberation Mono Thorndale -> Liberation Serif StarSymbol -> OpenSymbol Arial -> Liberation Sans Courier New -> Liberation Mono Times New Roman -> Liberation Serif Sounds good to me. UI Tests will likely fail. @Timur I. Davletshin, would you like to provide a commit fixing this issue? See https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch for more info... (In reply to Xisco Faulí from comment #5) > @Timur I. Davletshin, would you like to provide a commit fixing this issue? > See https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch for > more info... Oh, no. I'm just a mere LO user ))) Laurent, would your patch fix this issue and bug 114749 at the same time ? (In reply to Xisco Faulí from comment #7) > Laurent, would your patch fix this issue and bug 114749 at the same time ? Actually, I only applied the patch, but it should. Pending review: https://gerrit.libreoffice.org/63303/ https://gerrit.libreoffice.org/63141/ No further input from UX needed. (In reply to Laurent BP from comment #8) > (In reply to Xisco Faulí from comment #7) > > Laurent, would your patch fix this issue and bug 114749 at the same time ? > > Actually, I only applied the patch, but it should. > Pending review: > https://gerrit.libreoffice.org/63303/ > https://gerrit.libreoffice.org/63141/ I'm not sure if this should be treated along with mentioned bug but there is also html.stw file which uses old StarOffice fonts too. Probably it should be fixed manually. (In reply to Laurent BP from comment #8) > (In reply to Xisco Faulí from comment #7) > > Laurent, would your patch fix this issue and bug 114749 at the same time ? > > Actually, I only applied the patch, but it should. > Pending review: > https://gerrit.libreoffice.org/63303/ > https://gerrit.libreoffice.org/63141/ There is another related problem — pri-marine_f.ott uses Sheffield font which AFAIK doesn't have any free alternative. So, probably it's better to substitute it with something of similar style. (In reply to Timur I. Davletshin from comment #10) > I'm not sure if this should be treated along with mentioned bug but there is > also html.stw file which uses old StarOffice fonts too. Probably it should > be fixed manually. html.stw is actually a zip file with xml content. I treated it with other *.ott and *.ots (In reply to Laurent BP from comment #8) > (In reply to Xisco Faulí from comment #7) > > Laurent, would your patch fix this issue and bug 114749 at the same time ? > > Actually, I only applied the patch, but it should. > Pending review: > https://gerrit.libreoffice.org/63303/ > https://gerrit.libreoffice.org/63141/ Does this mean that all templates shipped with LibO will use, and display the same fonts? If not, can that patch/whatever be applied to all templates that ship with LibO. (In reply to jonathon from comment #13) > Does this mean that all templates shipped with LibO will use, and display > the same fonts? > If not, can that patch/whatever be applied to all templates that ship with > LibO. Which template still use other fonts? See bug 114749 Laurent BP committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/3d9c00cee88f5821ac6fd36780ccfe8fef74c1ad%5E%21 tdf#113720 Apply script to modify fonts It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Laurent, can you please close all those bugs as Fixed, if fixed? Laurent BP committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/d3b6d4cd9f84d9461f2effdf2d0c48d90fa4a2c4%5E%21 tdf#113720 Apply script to modify fonts It will be available in 6.2.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Aha, so this was what converted "Arial Unicode MS" into "Liberation Sans Unicode MS" :-D see 502c31cc73b2c3c6aac2df626a8c26b5bac8b1bb |