| Summary: | Regression - selected character set not honoured when importing from Lotus .123 format | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Tomáš Hajný <XHajT03> |
| Component: | filters and storage | Assignee: | David Tardon <dtardon> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | alonso, aron.budea, dtardon, serval2412 |
| Priority: | medium | ||
| Version: | 5.4.2.2 release | ||
| Hardware: | x86-64 (AMD64) | ||
| OS: | Windows (All) | ||
| Whiteboard: | libwps target:6.1.0 target:6.0.0.1 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: | Example file showing the problem as requested | ||
|
Description
Tomáš Hajný
2017-11-23 00:30:22 UTC
Please upload a sample file. Created attachment 137951 [details]
Example file showing the problem as requested
Attachment provided as requested. Hello, oops, this is my fault(*), I have committed a patch to correct this problem in libwps https://sourceforge.net/p/libwps/code/ci/2a3465442d1305c7fec55e986c9793a86e571baa/. However, it is still possible to use the previous filter by choosing by hand the filter: "Lotus 1-2-3: (*.wk1, *.wk3, *.123)" (*) I assumed faulty that this file was a mac's file :-~ Please note that I didn't select a particular filter or its version (the previous comment by "osnola" kind of suggests that this might be the case), the filter was selected automatically when launching LibreOffice by double-clicking the .123 file. BTW, it's also interesting that the character set conversion dialogue (part of the filter) isn't translated/localized to Czech (while all other dialogues are localized) - this is just a cosmetic thing, though, not really important for me. Okay, since this just missed libwps release, let's put it into LibreOffice as an extra patch. David Tardon committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=54ec0aec1308bbbb8c9ab36fc76fe993bb23e5fb tdf#114000 always use user-selected charset It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. (In reply to Tomáš Hajný from comment #5) > BTW, it's also interesting that the character set conversion dialogue (part > of the filter) isn't translated/localized to Czech (while all other > dialogues are localized) - this is just a cosmetic thing, though, not really > important for me. The writerperfect module, which contains this dialog, was not included for translation in 5.x by a mistake. David Tardon committed a patch related to this issue. It has been pushed to "libreoffice-6-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=804f9278451b50daae82618cacbeb8931e773caa&h=libreoffice-6-0 tdf#114000 always use user-selected charset It will be available in 6.0.0.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. I can confirm that the daily build libo-60-64~2017-12-05_02.52.19_LibreOfficeDev_6.0.0.0.beta1_Win_x64.msi behaves correctly with respect to this bug report - thanks for fixing it! |