Bug 114117

Summary: draw: page shadow issue.
Product: LibreOffice Reporter: Michael Meeks <michael.meeks>
Component: graphics stackAssignee: Caolán McNamara <caolan.mcnamara>
Status: RESOLVED FIXED    
Severity: normal CC: caolan.mcnamara
Priority: medium    
Version: 6.0.0.0.beta1   
Hardware: All   
OS: All   
Whiteboard: target:6.1.0 target:6.0.0.1
Crash report or crash signature: Regression By:
Attachments: shadow surround of a page =)

Description Michael Meeks 2017-11-28 13:57:32 UTC
I'm using Linux builds vs. a recent master: 9c060802747e0b058a162e7891508d888c6e1a73

$ rpm -qf /usr/lib64/libcairo.so.2.11502.0 
libcairo2-1.15.2-7.1.x86_64

I fire up draw, and I get this problem: I guess this is caused by Cairo's image scaling behaving rather differently to what we expect - I believe the writer page surround is rendered differently but draw/impress uses: the drawing-layer DiscreteShadowPrimitive2D which in turn uses the DrawTransformBitmapExDirect (I guess).

Picture attached; with the same code I see the correct surround using the 'gen' or kde4 backends - interestingly. =)
Comment 1 Michael Meeks 2017-11-28 14:00:40 UTC
Created attachment 138042 [details]
shadow surround of a page =)
Comment 2 Commit Notification 2017-11-29 20:41:39 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ba4a124b0c0c66fd275f5147d55eeec27ce78da9

Resolves: tdf#114117 draw page shadow mangled

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2017-12-01 11:06:13 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=335ae97f4fdb70d3325a8337d27232ca610228fc&h=libreoffice-6-0

Resolves: tdf#114117 draw page shadow mangled

It will be available in 6.0.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.