Bug 114694

Summary:	Make "Default: <Name>" entry in language settings lists not sorted, possibly separated from other items
Product:	LibreOffice	Reporter:	Mike Kaganski <mikekaganski>
Component:	LibreOffice	Assignee:	Yusuf Keten <ketenyusuf>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kara, mentoring, vsfoote, xiscofauli
Priority:	medium	Keywords:	difficultyInteresting, easyHack, skillCpp, skillUI
Version:	unspecified
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=139415
Whiteboard:	target:7.0.0
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	112139

Description Mike Kaganski 2017-12-26 03:18:38 UTC

Language options include several language choice lists (UI and locale language, default languages for documents), as well as default currency list, all of which include a special item "Default: <Name>", which means that this setting becomes "unset" and defaults apply to it.

The item is sorted among other items alphabetically, making it appear somewhere among languages starting with the same letter as the word "Default" translated to current UI language. It is not obvious where to search for the item, because if there are no default items on the page, one has to guess which term (and which translation) was used: is it "Standard"? or "Default"?

The proposal is to make the items not sorted (topmost; maybe separated from the rest of list by a horizontal line, like last-used fonts in font drop-down in Formatting toolbar).

Comment 1 V Stuart Foote 2017-12-26 17:06:11 UTC

Agree, Default entry should appear at top of listing and be unsorted--that is the better UI. And a separator would be helpful.

Comment 2 Mike Kaganski 2019-04-05 17:19:33 UTC

A code pointer (for an implementation): see OfaViewTabPage::OfaViewTabPage in cui/source/options/optgdlg.cxx (Options ▸ LibreOffice ▸ View), which populates icon style list box, setting the "automatic" entry as the first element, and puts a separator after it.

Comment 3 Mike Kaganski 2019-04-05 19:29:45 UTC

... and the code populating the language lists is also in that file, in OfaLanguagesTabPage::OfaLanguagesTabPage, where the lists (e.g., m_pWesternLanguageLB) are set to sorted; and InsertDefaultLanguage is called.

Comment 4 Commit Notification 2020-02-11 17:26:48 UTC

Yusuf Keten committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5326d238d7f98b11886eb4be01f19db73f8eda39

tdf#114694: Make default value in language settings the first element

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.