Bug 114949

Summary: FILESAVE: Position or vertical or oblique lines lost in XML format (docx)
Product: LibreOffice Reporter: Silvain Dupertuis <silvain-dupertuis>
Component: WriterAssignee: Not Assigned <libreoffice-bugs>
Status: RESOLVED DUPLICATE    
Severity: normal CC: aron.budea, ilmari.lauhakangas, jalojo, kelemeng, raal, xiscofauli
Priority: medium Keywords: bibisected, bisected, filter:docx, regression
Version: 4.3 all versions   
Hardware: x86 (IA32)   
OS: All   
See Also: https://bugs.documentfoundation.org/show_bug.cgi?id=70838
Whiteboard:
Crash report or crash signature: Regression By:
Attachments: test file
compare
Screenshot of the original and exported document in current master

Description Silvain Dupertuis 2018-01-10 14:49:10 UTC
Description:
Position of vertical lines are lost when saving in XML format, whatever the anchor and the reference for mesurements.
It works well with Word 97-2003 (.doc) format, but not with Word 2007-2013 XML (docx).

Steps to Reproduce:
1.Create a document with vertical (or oblique) line(s)
2.Save as Word 2007-2013 XML (docx) and close
3.Reopen the document

Actual Results:  
Positions of lines are altered, and lines may be lost depending of whcih combination of anchor - reference of mesurement.

Expected Results:
Keep correct positions


Reproducible: Always


User Profile Reset: No



Additional Info:
Apparently, positons of horizontal lines work correctly.


User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
Comment 1 raal 2018-01-10 16:59:33 UTC
I can confirm with Version: 6.1.0.0.alpha0+
Build ID: 834cebd153573eea3cc321eca5bcb572b4776dec
CPU threads: 4; OS: Windows 6.1; UI render: default; 
and Version: 4.4.0.0.alpha0+
Comment 2 raal 2018-01-10 17:00:11 UTC
Created attachment 139024 [details]
test file
Comment 3 raal 2018-01-10 17:00:54 UTC
Created attachment 139025 [details]
compare
Comment 4 Jacques Guilleron 2018-01-10 18:10:03 UTC
Hi Silvain, Raal,

worked till:
LO 4.2.8.1 Build ID: 4044db1653798618515c987464157abee9229c11

but not with:
LO 4.3.0.0.beta1 Build ID: b7cfa1eab1cb1e94f71d6df6612b73f231d0bf92
and upper versions under windows 7
Comment 5 Jacques Guilleron 2018-01-10 18:54:31 UTC
Vertical Lines Positions were also reserved in XML format with
LO 4.2.8.2 Build ID: 48d50dbfc06349262c9d50868e5c1f630a573ebd
Comment 6 Buovjaga 2018-07-10 11:57:42 UTC Comment hidden (obsolete)
Comment 7 Buovjaga 2018-07-10 12:16:30 UTC Comment hidden (obsolete)
Comment 8 Aron Budea 2018-08-09 03:35:15 UTC
Bibisecting using repo bibisect-43max points to two incorrect states, first the slanted lines is only positioned slightly lower than the vertical one in the DOCX, and later they become positioned below one another (as in raal's comparison screenshot).

Bibisecting the first change yields the following range (LO crashed in between):
https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=cbce7443b2fa0c1304ff94a54eb48da0c4518146..363119a9f2f0710a55530909330efb343d5a8bae

Bibisecting the second change yields the following commit:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=1393ba60b1eb43b55820f74c393da04308221d97
author		Jacobo Aragunde Pérez <jaragunde@igalia.com>	2014-04-14 18:53:34 +0200
committer	Jacobo Aragunde Pérez <jaragunde@igalia.com>	2014-04-15 11:35:49 +0200

"fdo#70838: fix rotation transformation in DML exporter
This patch fixes an error in commit c6ff03f37a6898f50a5ca07152168fb4fe911e05."

The referred commit is in the range above, so I'm assuming that's what caused the first change:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=c6ff03f37a6898f50a5ca07152168fb4fe911e05
author		Jacobo Aragunde Pérez <jaragunde@igalia.com>	2014-03-22 13:16:52 +0100
committer	Jacobo Aragunde Pérez <jaragunde@igalia.com>	2014-03-22 23:58:15 +0100

fdo#70838: apply rotation transformations to DML anchor position
Comment 9 QA Administrators 2019-08-19 06:54:49 UTC Comment hidden (obsolete)
Comment 10 Gabor Kelemen (allotropia) 2020-04-14 20:48:24 UTC
Created attachment 159566 [details]
Screenshot of the original and exported document in current master

This seems to be fixed in bibisect-linux-64-6.5:

Version: 7.0.0.0.alpha0+
Build ID: 35fc5ef0a759884b24ed8b83cd05702a0fab64cc
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: hu-HU (hu_HU.UTF-8); UI-Language: en-US
Calc: threaded

This got better after:

https://git.libreoffice.org/core/+/08a11f8fe19560b000c62da00d7425b4f500d605%5E%21

author	Szabolcs <szabolcs450@gmail.com>	Tue Mar 24 15:38:14 2020 +0100
committer	László Németh <nemeth@numbertext.org>	Wed Apr 08 12:54:45 2020 +0200

tdf#104565 DOCX drawing object export: fix arrow positions
Comment 11 Gabor Kelemen (allotropia) 2020-04-14 20:49:15 UTC

*** This bug has been marked as a duplicate of bug 104565 ***