| Summary: | AdminConsole: control logging ... | ||
|---|---|---|---|
| Product: | LibreOffice Online | Reporter: | Michael Meeks <michael.meeks> |
| Component: | LibreOffice | Assignee: | Gökay ŞATIR <gokaysatir> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | aron.budea, mentoring |
| Priority: | medium | Keywords: | difficultyMedium, easyHack, skillCpp, skillJavaScript, topicCleanup |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:7.1.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 123137 | ||
Hello, Can i work on this task? Sure ! =) go for it ... gokaysatir committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/online/commit/ac682772a6edf4045371670552a9c831623d45f4 tdf#114982 - AdminConsole: control logging Things done: * Set log level of each channel. * View the log via admin console. * Update protocol.txt Things to be done: * Propagate the new log level to the WSD children including forkit. This task still needs some work to be done. I will send one more patch. This will take a while. Thank you for leading the way:) I didn't forget this one :) After some months. This bug is ready to be closed. Below task is also done and merged into master branch. * Propagate the new log level to the WSD children including forkit. |
It would be extremely useful to be able to turn up and down the log-level on the admin-console (and to browse the logs but that's something else ;-) dynamically at run time. This belongs in the 'Settings' page - checkout: loleaflet/dist/admin/adminSettings.html loleaflet/src/admin/AdminSocketSettings.js To add the log level setting and then: wsd/Admin.cpp- else if (tokens[0] == "settings") wsd/protocol.txt: needs updating too. And of course we need to set the log level with: Log::logger().setLevel(LogLevel); For bonus points we should really propagate this to all the WSD children too including the forkit - but that is a fair bit of protocol work & tweaking =) Thanks !