| Summary: | Crash in: BitmapReadAccess::SetPixelForN24BitTcRgb(unsigned char *,long,BitmapColor const &,ColorMask const &) if OpenGL is enabled | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Thomas Lendo <thomas.lendo> |
| Component: | Writer | Assignee: | Miklos Vajna <vmiklos> |
| Status: | VERIFIED FIXED | ||
| Severity: | critical | CC: | aron.budea, dgp-mail, quikee, serval2412, telesto, vmiklos, xiscofauli |
| Priority: | highest | Keywords: | wantBacktrace |
| Version: | 5.4.3.2 release | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=119732 | ||
| Whiteboard: | target:6.1.0 target:6.0.5 | ||
| Crash report or crash signature: | ["BitmapReadAccess::SetPixelForN24BitTcRgb(unsigned char *,long,BitmapColor const &,ColorMask const &)"] | Regression By: | |
| Bug Depends on: | |||
| Bug Blocks: | 94691 | ||
| Attachments: |
File where the crash happens, password: BdT8GfhSLBpuxTgZ
Screenshot of testfile: on the left without GL, on the right with activated GL |
||
|
Description
Thomas Lendo
2018-03-12 15:42:13 UTC
I could open the file with no crash in Version: 5.4.6.1 (x64) Build-ID: 7d6c666f03cf1f0a0c2c51a17c0f67a8d5a8012b CPU-Threads: 4; BS: Windows 6.19; UI-Render: Standard; Gebietsschema: de-DE (de_DE); Calc: group I saved the document and opened it with Version: 6.1.0.0.alpha0+ (x64) Build ID: d64ce643275e0b2b0dea9e532fc261391dc8793c CPU threads: 4; OS: Windows 10.0; UI render: GL; TinderBox: Win-x86_64@42, Branch:master, Time: 2018-03-01_03:24:30 Locale: de-DE (de_DE); Calc: CL => Crash I disabled OpenGL => No crash with 6.1.0.0.alpha0+ Again an OpenGL related crash. Hope it really helps in perf when it works because there are quite a lot of this kind. Thank for the report - quikee - can you take a look ? Repro with Version: 6.1.0.0.alpha0+ Build ID: 42b80f4ed300b08074ed3a6dd48679afd5af760a CPU threads: 4; OS: Windows 6.3; UI render: GL; Locale: nl-NL (nl_NL); Calc: CL but not with Version: 6.1.0.0.alpha0+ Build ID: 546ed01e62c9a36a675c7390371aaec7f1647a33 CPU threads: 4; OS: Windows 6.3; UI render: GL; TinderBox: Win-x86@42, Branch:master, Time: 2018-03-26_15:39:48 Locale: nl-NL (nl_NL); Calc: CL I don't get a crash, but instead I get a black image at the bottom of the page when GL is enabled. The image shows fine when GL is off. I plan to take a look at that. Miklos Vajna committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a3cbd06872b2f9ee9253e5879f590ff1b9eaf365 tdf#116365 vcl opengl: respect max texture size when creating textures It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Miklos Vajna committed a patch related to this issue. It has been pushed to "libreoffice-6-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=443b2e6359955b107ba951636b2491b9444d0fee&h=libreoffice-6-0 tdf#116365 vcl opengl: respect max texture size when creating textures It will be available in 6.0.5. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Created attachment 141888 [details] Screenshot of testfile: on the left without GL, on the right with activated GL Miklos, thanks very much for your patch! A follow-up question: The image isn't causing a crash or a black object anymore, but with activated GL the picture is stretched in the length (but the total length of the image, as shown in the document, is the same as before). The attached screenshot shows the original and correct displayed image without GL on the left, the right side shows the stretched image with activated GL. Tested with version 6.1.0.0.alpha1+ (x64) Build ID: 409b7636f0e519f9ab14bac7884789b2323557c7 CPU threads: 8; OS: Windows 10.0; UI render: GL; TinderBox: Win-x86_64@42, Branch:master, Time: 2018-05-03_23:47:22 Locale: de-AT (de_AT); Calc: CL (In reply to Thomas Lendo from comment #8) > A follow-up question: > The image isn't causing a crash or a black object anymore => VERIFIED FIXED |