Bug 116392

Summary: Customize dialog: Reset button crash
Product: LibreOffice Reporter: Jim Raykowski <raykowj>
Component: WriterAssignee: Not Assigned <libreoffice-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: ilmari.lauhakangas, raykowj, tmplee, xiscofauli
Priority: medium    
Version: 6.1.0.0.alpha0+   
Hardware: All   
OS: All   
Whiteboard:
Crash report or crash signature: Regression By:

Description Jim Raykowski 2018-03-14 01:10:06 UTC 
Version: 6.1.0.0.alpha0+
Build ID: 724d34d58b437843e40aaa74008d94cac1465cea
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk2; 
Locale: en-US (en_US.UTF-8); Calc: group

1. Menu > Tools > Customize
2. Click Reset button
Crash

Regression from:

Commit 00431a8afcad08da11835131c2cd423d7f8cd115
Author: Noel Grandin <noel.grandin@collabora.co.uk>, Tue Mar 13 11:57:33 2018 +0200 (15 hours ago)
Committer: Noel Grandin <noel.grandin@collabora.co.uk>, Tue Mar 13 12:40:42 2018 +0100 (13 hours ago)
Follows: libreoffice-6-0-branch-point
Branches: <Expand>

loplugin:useuniqueptr in SvxEntries

Change-Id: I4e105326ddba11822beb9affe97196c77a5baf4b
Reviewed-on: https://gerrit.libreoffice.org/51203
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

SvxConfigEntry::~SvxConfigEntry()
Comment 1 Jacques Guilleron 2018-03-14 10:05:51 UTC 
HI Jim,

I don't reproduce with:
LO  6.1.0.0.alpha0+ Build ID: 0d1479cbd442c3ec3bdd20333c341ea24dcca21e
CPU threads: 2; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-03-10_01:47:26
Locale: en-GB (fr_FR); Calc: CL
I get the warning:
"The menu configuration for LibreOfficeDev Writer will be reset to the default settings. Do you want to continue?"
Comment 2 Buovjaga 2018-03-14 15:52:18 UTC 
Muhammet poked Noel about another crash, so this is probably fixed by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=3a0ae2aae3f226e5e2e3785e578dee3ab4d2fa35
Comment 3 Xisco Faulí 2018-03-14 19:19:27 UTC 
I can't reproduce it in

Version: 6.1.0.0.alpha0+
Build ID: 6a9326803c01f4c9bc7da855053ce4e80646fad8
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk2; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

tried also in safe mode...
Comment 4 Jim Raykowski 2018-03-14 22:29:08 UTC 
(In reply to Buovjaga from comment #2)
> Muhammet poked Noel about another crash, so this is probably fixed by:
> https://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=3a0ae2aae3f226e5e2e3785e578dee3ab4d2fa35

Yes this fixed it.
Comment 5 Buovjaga 2018-03-24 09:09:20 UTC 
*** Bug 116463 has been marked as a duplicate of this bug. ***