| Summary: | Crash inserting Fontwork | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Telesto <telesto> |
| Component: | Calc | Assignee: | Armin Le Grand <Armin.Le.Grand> |
| Status: | VERIFIED FIXED | ||
| Severity: | critical | CC: | Armin.Le.Grand, bip, raal, rb.henschel, serval2412, xiscofauli |
| Priority: | highest | Keywords: | bibisected, bisected, haveBacktrace, needUITest, regression |
| Version: | 6.1.0.0.alpha0+ | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:6.1.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 116979 | ||
| Attachments: |
gdb backtrace
bt with debug symbols |
||
|
Description
Telesto
2018-04-13 14:32:39 UTC
Regression introduced by: author Armin Le Grand <Armin.Le.Grand@cib.de (CIB)> 2018-03-01 15:54:32 +0100 committer Armin Le Grand <Armin.Le.Grand@cib.de> 2018-04-07 00:28:30 +0200 commit dfefe448c41921f2f1e54d3f69b8b9e89031d055 (patch) tree 1aace31054b5740e2faffcbc5de66a791be27f7d parent eba4d5b2b76cefde90cb3d6638c736f435023a45 (diff) SOSAW080: Added first bunch of basic changes to helpers Bisected with: bibisect-linux64-6.1 Adding Cc: to Armin Le Grand Created attachment 141340 [details]
gdb backtrace
Created attachment 141373 [details]
bt with debug symbols
On pc Debian x86-64 with master sources updated 2 days ago, I could reproduce this.
I attached a bt because it's different from the one already provided.
+ I let warn logs from console.
It is an Assertion File: core/svl/source/items/itempool.cxx Line: 620 Expression: !pImpl->mpStaticDefaults||typeid(rItem)==typeid(GetDefaultItem(nWich)) tested with Version: 6.1.0.0.alpha0+ (x64) Build ID: 8b34efff7a7ed13553dfe87cd2413d01c76dec1d CPU threads: 8; OS: Windows 10.0; UI render: default; Locale: de-DE (de_DE); Calc: CL *** Bug 117422 has been marked as a duplicate of this bug. *** Can reproduce. FontWorkGalleryDialog member mpDestModel is NULL. Checking if this is the case in lo-6-0... Same in lo-6-0 -> one of the 'hidden' errors which comes up due to the changes. Seems a 'extra' mode for Calc is in place that uses FontWorkGalleryDialog::SetSdrObjectRef to set 'SdrObject** mppSdrObject' and 'SdrModel* mpDestModel'. This is 'only' called in Calc -> tehse two vars are NULL in other apps -> mpDestModel is *not always* the correct destination SdrModel (despite it's name...). lo-6-0 uses 'mpSdrView->InsertObjectAtView' as target for the new SdrModel, so the SDrModel from that SdrView *should* be the correct one. This example shows why I do this cleanups... Fix on gerrit (see https://gerrit.libreoffice.org/#/c/54045/) Armin Le Grand committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=9ddbd8e2bce697ce244a1f6161e8f45312f6e6b2 tdf#116993 corrected FontWork to use correct SdrModel It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Checked with current master (fix is in), could not reproduce anymore *** Bug 117652 has been marked as a duplicate of this bug. *** Verified in Version: 6.1.0.0.alpha1+ Build ID: db608e8e5e27cce8eeda26918bcab71222d342df CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk3; Thanks for the fix. |