Bug 117178

Summary: GTK3: selected thumbnailview is completely black in high contrast
Product: LibreOffice Reporter: Xisco Faulí <xiscofauli>
Component: UIAssignee: Caolán McNamara <caolan.mcnamara>
Status: VERIFIED FIXED    
Severity: normal CC: caolan.mcnamara, xiscofauli
Priority: medium Keywords: accessibility, bibisected, bisected
Version: 5.3 all versions   
Hardware: All   
OS: Linux (All)   
Whiteboard: target:6.1.0
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 103182    
Attachments: how it looks in GTK3
how it looks in GTK2

Description Xisco Faulí 2018-04-23 13:12:04 UTC 
Created attachment 141559 [details]
how it looks in GTK3

Steps to reproduce:
1. Change accessibility theme to High Contrast ( How to do it on ubuntu -> https://www.youtube.com/watch?v=IEDp--6x8cs )
2. Open LibreOffice with GTk3

Observed behaviour: Text in selected thumbnailview should be readable. See attached image

Reproduced in

Version: 6.1.0.0.alpha0+
Build ID: e31a5365091d8658ecce374bbc339a9d832e1a15
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group
Comment 1 Xisco Faulí 2018-04-23 13:12:46 UTC 
Created attachment 141560 [details]
how it looks in GTK2
Comment 2 Xisco Faulí 2018-04-23 13:13:39 UTC 
This behaviour started after https://cgit.freedesktop.org/libreoffice/core/commit/?id=596065ff05165f5b59cfcfdcee09166931455e19

@Caolán, one for you?
Comment 3 Caolán McNamara 2018-04-27 10:50:19 UTC 
I can probably do something about that
Comment 4 Commit Notification 2018-04-27 15:22:46 UTC 
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=1d7349476b98dff8038ad44f7806fd404b68c993

Related: tdf#117178 rollover is always done in visually released button mode

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2018-04-27 15:24:05 UTC 
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=42494bfdd029c69cca7f0979a0ed3ab920efe45e

Resolves: tdf#117178 distinguish between pressed vs unpressed rollover

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Caolán McNamara 2018-04-27 15:32:16 UTC 
that seems to work
Comment 7 Xisco Faulí 2018-04-27 16:28:37 UTC 
Verified in

Version: 6.1.0.0.alpha1+
Build ID: 42494bfdd029c69cca7f0979a0ed3ab920efe45e
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

Caolán, Thanks for fixing this!