| Summary: | double display slightly offset when editing a cell | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Jean-Baptiste Faure <jbfaure> |
| Component: | Calc | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caolan.mcnamara, ilmari.lauhakangas, kos, xiscofauli |
| Priority: | medium | ||
| Version: | 6.0.4.1 rc | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:6.1.0 target:6.0.5 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 108252, 112128 | ||
| Attachments: | the second cell is double-clicked for editing | ||
|
Description
Jean-Baptiste Faure
2018-05-03 14:47:23 UTC
I repro. Arch Linux 64-bit Version: 6.1.0.0.alpha1+ Build ID: 03a4b6eb58b29c0ab4bb85f756923c46618d02ff CPU threads: 8; OS: Linux 4.16; UI render: default; VCL: gtk3; Locale: fi-FI (fi_FI.UTF-8); Calc: group Built on May 2nd 2018 maybe this is some sort of self drawing problem where the source and target are the same surface and source and destination overlap if you can reproduce it (which I can't, as is typical) can you see if https://gerrit.libreoffice.org/#/c/53860/ makes a difference, and what "type is" value gets output ? (In reply to Caolán McNamara from comment #3) > if you can reproduce it (which I can't, as is typical) can you see if > https://gerrit.libreoffice.org/#/c/53860/ makes a difference, and what "type > is" value gets output ? It does make a positive difference - I am not seeing the mess anymore! I also tested the other VCL backends to be sure they stayed healthy. (In reply to Buovjaga from comment #4) > (In reply to Caolán McNamara from comment #3) > > if you can reproduce it (which I can't, as is typical) can you see if > > https://gerrit.libreoffice.org/#/c/53860/ makes a difference, and what "type > > is" value gets output ? > > It does make a positive difference - I am not seeing the mess anymore! I > also tested the other VCL backends to be sure they stayed healthy. Ah, sorry, the output is: type is 3 ok, thats encouraging. So here's my proposed final patch https://gerrit.libreoffice.org/#/c/53860/ I assume that still works ? (In reply to Caolán McNamara from comment #3) > if you can reproduce it (which I can't, as is typical) can you see if > https://gerrit.libreoffice.org/#/c/53860/ makes a difference, and what "type > is" value gets output ? That makes a difference: no problem anymore. It still works as expected if gtk2 backend is used instead of gtk3 type is 3 if gtk3, no output if gtk2. Best regards. JBF (In reply to Caolán McNamara from comment #6) > ok, thats encouraging. So here's my proposed final patch > https://gerrit.libreoffice.org/#/c/53860/ I assume that still works ? Yep, it still works. Sadly Jenkins complains about a failed unit test on Win https://ci.libreoffice.org/job/gerrit_windows/5323/console (In reply to Buovjaga from comment #8) > (In reply to Caolán McNamara from comment #6) > > ok, thats encouraging. So here's my proposed final patch > > https://gerrit.libreoffice.org/#/c/53860/ I assume that still works ? > > Yep, it still works. Idem for me. > > Sadly Jenkins complains about a failed unit test on Win > https://ci.libreoffice.org/job/gerrit_windows/5323/console No problem with unit tests for me under Linux. Best regards. JBF excellent, windows failure is bogus wrt this patch as its not on the windows code path. will try build again, picked to proposed 6-0 in gerrit in the meantime Caolán McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=95620da00dc53a061c3b093510e46a7c0b3163c6 Resolves: tdf#117413 char doubling appearing under X with gtk3 It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Thank you very much, this patch fixes the bug for me on master. If needed I can test the cherrypicked patch for 6.0. Best regards. JBF *** Bug 117605 has been marked as a duplicate of this bug. *** Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-6-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=17e7bd5e17e3393c44c76b7c69d47ad112e5efa6&h=libreoffice-6-0 Resolves: tdf#117413 char doubling appearing under X with gtk3 It will be available in 6.0.5. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. I was affected by this bug in Ubuntu 16.04. In LO Calc v5.x, editing existing data was superimposed on the old data while that field is being edited. At the end of editing (ENTER) the new data appeared correctly. The problem was while editing you could not see what you doing. I installed LO v6.x and the bug is gone. --thanks |